Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to LoadISISNexus documentation #19408

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

Anders-Markvardsen
Copy link
Member

Some smaller changes to wordings in section "Data loaded from Nexus File" of LoadISISNexus.
(needed for a sine2020 report)

To test:

  • Test that changes to wordings are acceptable

Fixes #19400.

RELEASE NOTES
Does not need to be in the release notes.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@Anders-Markvardsen Anders-Markvardsen added the Documentation Issues and pull requests related to documentation label Apr 20, 2017
@Anders-Markvardsen Anders-Markvardsen added this to the Release 3.10 milestone Apr 20, 2017
@DavidFair DavidFair self-assigned this Apr 21, 2017
@DavidFair
Copy link
Contributor

LGTM :shipit:

@martyngigg martyngigg self-assigned this Apr 24, 2017
@martyngigg martyngigg merged commit 7f644ea into master Apr 24, 2017
@martyngigg martyngigg deleted the 19400_loadisisnexus_doc_updates branch April 24, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants