-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes and unit tests for AlignAndFocusPowder Refs #23888 #24409
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall a great improvement as demonstrated by the bugs found and fixed. The changes requested are code style/convention.
int numEvents = 10000) { | ||
inputWS = "eventWS"; | ||
|
||
CreateSampleWorkspace createSampleAlg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a good idea (follow-on PR) to make this the default functionality for CreateSampleWorkspace(Function='Powder Diffraction', ...)
as having the instrument centered on two_theta=90 is fairly common.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue created #24411
Description of work.
Adds unit test for
AlignAndFocusPowder
with bug fixes found during the test development.Bug fixes:
AlignAndFocusPowder
with theGroupingFilename
it will extract the grouping workspace without applying the mask and pass this to the child algorithmDiffractionFocussing
with theGroupingWorkspace
argument. Yet if you callDiffractionFocussing
with theGroupingFileName
argument, it will go ahead and apply the mask. Thus, to makeAlignAndFocusPowder
with theGroupingFilename
work the same way asDiffractionFocussing
with theGroupingFileName
argument, the mask is now applied to the grouping workspace passed toDiffractionFocussing
as theGroupingWorkspace
argument.To test:
WorkflowAlgorithmsTest
testsAlignAndFocusPowderTest
test suiteExample script for step 2 and 3:
ninja && ninja WorkflowAlgorithmsTest && ctest -R AlignAndFocusPowderTest
NOTE: If it helps, for manually setting up the tests on HRPD test files in the
ExternalDataStore
, the following python script helped me plot results to figure out when I encountered bugs. (has .txt file extension so GitHub would let me upload)alignfocuspowder_testing.txt
Fixes #8929, fixes #17840, and fixes #23888
Refs #17841, #19105, #19109, #22602, #23869, and #24386
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.