Indirect - Update F(Q) fit functions and documentation #24418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertapplin
added
Indirect/Inelastic
robertapplin
added a commit
that referenced
this pull request
Jan 7, 2019
TTitcombe
reviewed
Jan 8, 2019
robertapplin
force-pushed
the
Indirect_UpdateFitFunctions
branch
2 times, most recently
from
be0a6ef
to
2b835cb
Compare
robertapplin
added a commit
that referenced
this pull request
Jan 10, 2019
robertapplin
force-pushed
the
Indirect_UpdateFitFunctions
branch
from
2b835cb
to
1f93777
Compare
robertapplin
added a commit
that referenced
this pull request
Jan 15, 2019
soininen
suggested changes
Jan 29, 2019
robertapplin
force-pushed
the
Indirect_UpdateFitFunctions
branch
from
d0f7e7f
to
12dfcf7
Compare
robertapplin
added a commit
that referenced
this pull request
Feb 4, 2019
robertapplin
added a commit
that referenced
this pull request
Feb 4, 2019
robertapplin
added a commit
that referenced
this pull request
Feb 4, 2019
robertapplin
force-pushed
the
Indirect_UpdateFitFunctions
branch
from
12dfcf7
to
f517364
Compare
robertapplin
added a commit
that referenced
this pull request
Feb 4, 2019
robertapplin
added a commit
that referenced
this pull request
Feb 4, 2019
robertapplin
added a commit
that referenced
this pull request
Feb 4, 2019
robertapplin
added a commit
that referenced
this pull request
Feb 4, 2019
robertapplin
added a commit
that referenced
this pull request
Feb 4, 2019
robertapplin
force-pushed
the
Indirect_UpdateFitFunctions
branch
from
36234d9
to
2858680
Compare
|
@soininen this should be ready to go now |
soininen
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work.
This PR introduces updated fit functions and documentation for Hall Ross, Chudley-Elliot and Teixeira Water.
To test:
Read the updated documentation and check that the HWHM within the scripts match those within the documentation for Hall Ross and Chudley-Elliot.
Fixes #24417
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.