Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RunNumber to Each Workspace in Multi-Period Event Data #24600

Merged
merged 2 commits into from
Jan 25, 2019

Conversation

TTitcombe
Copy link
Contributor

Description of work.
Swap the ordering of adding information to logs in LoadEventNexus so that metadata is added before we copy the metadata to each workspace in the collection

Report to: nobody

To test:
In Mantid, load LARMOR13065. (this is in ExternalData/Testing/Data/SystemTest/LARMOR of your build directory)
This should produce a group workspace with 4 constituents.
Right click on each individual workspace and click sample logs.
The logs should contain mostly the same elements, but this PR is specifically to ensure that each workspace has the property run number, and the value should be 13065 in each workspace.

Fixes #24583

This does not require release notes because internal change


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@TTitcombe TTitcombe added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jan 25, 2019
@TTitcombe TTitcombe added this to the Release 3.14 (4.0?) milestone Jan 25, 2019
@LowriJenkins LowriJenkins self-assigned this Jan 25, 2019
Copy link
Contributor

@LowriJenkins LowriJenkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes function as described, and only change in code is moving a section earlier.

@martyngigg martyngigg merged commit 26aaec4 into master Jan 25, 2019
@martyngigg martyngigg deleted the 24583_event_nexus_loads_without_run_numbers branch January 25, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants