Add RunNumber to Each Workspace in Multi-Period Event Data #24600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work.
Swap the ordering of adding information to logs in
LoadEventNexus
so that metadata is added before we copy the metadata to each workspace in the collectionReport to: nobody
To test:
In Mantid, load
LARMOR13065
. (this is in ExternalData/Testing/Data/SystemTest/LARMOR of your build directory)This should produce a group workspace with 4 constituents.
Right click on each individual workspace and click
sample logs
.The logs should contain mostly the same elements, but this PR is specifically to ensure that each workspace has the property
run number
, and the value should be 13065 in each workspace.Fixes #24583
This does not require release notes because internal change
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.