Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change marker type for workbench sample logs plot #24626

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

rosswhitfield
Copy link
Member

The marker '.' was originally used so that single value logs would be observable, since #23742 there is always two values making this redundant.

Before:
figure_1-4

After:
figure_1-5

To test:

Compare plotting sample logs before and after this change. For the above plots I used ws=Load('PG3_42941',metaDataOnly=True)

There is no associated issue.

This does not require release notes because workbench


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

The marker '.' was originally used so that single value logs would be observable, since mantidproject#23742 there is always two values making this redundant.
@rosswhitfield rosswhitfield added Framework Issues and pull requests related to components in the Framework GUI Issues and pull requests specific to the Mantid Workbench GUI. labels Jan 28, 2019
@rosswhitfield rosswhitfield added this to the Release 3.14 (4.0?) milestone Jan 28, 2019
@gvardany gvardany merged commit 7791281 into mantidproject:master Feb 6, 2019
@rosswhitfield rosswhitfield deleted the sampleLogs_plots branch February 6, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework GUI Issues and pull requests specific to the Mantid Workbench GUI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants