Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indirect Unit tests for fitting models #24650

Merged
merged 11 commits into from
Feb 1, 2019

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Jan 30, 2019

Description of work.
This PR introduces unit tests for the various fitting models including ConvFitModel, JumpFitModel, IqtFitModel and MSDFitModel.

To test:
Make sure the tests pass.

No release notes - these are behind the scenes tests

Fixes #24649

Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@robertapplin robertapplin added State: In Progress Indirect/Inelastic Issues and pull requests related to indirect or inelastic labels Jan 30, 2019
@robertapplin robertapplin added this to the Release 3.14 (4.0?) milestone Jan 30, 2019
Copy link
Contributor

@TTitcombe TTitcombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are mostly new tests.
Test coverage seems good.
No need for release notes as internal tests.

TTitcombe
TTitcombe previously approved these changes Feb 1, 2019
TTitcombe
TTitcombe previously approved these changes Feb 1, 2019
@martyngigg martyngigg merged commit 4a7ccd7 into master Feb 1, 2019
@martyngigg martyngigg deleted the 0_IndirectFittingModelsUnitTests branch February 1, 2019 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants