-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for merging rows into the reflectometry GUI #26518
Merged
DanNixon
merged 4 commits into
mantidproject:master
from
gemmaguest:26512_add_refl_gui_merge_row_tests
Aug 12, 2019
Merged
Add unit tests for merging rows into the reflectometry GUI #26518
DanNixon
merged 4 commits into
mantidproject:master
from
gemmaguest:26512_add_refl_gui_merge_row_tests
Aug 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmaguest
added
Reflectometry
Issues and pull requests related to reflectometry
Not Ready
ISIS Team: LSS
Issue and pull requests managed by the LSS subteam at ISIS
labels
Jul 29, 2019
4 tasks
gemmaguest
force-pushed
the
26512_add_refl_gui_merge_row_tests
branch
from
July 29, 2019 17:41
90e1429
to
4043c6d
Compare
dtasev
suggested changes
Aug 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests look good, pass locally and on build servers. Some merge conflicts have arisen though
Remove unnecessary function pointer argument because this function is only called from one place so it is always the same. Re mantidproject#26512
Make listener a nice mock in line with other tests Re mantidproject#26512
gemmaguest
force-pushed
the
26512_add_refl_gui_merge_row_tests
branch
from
August 6, 2019 09:02
4043c6d
to
4e2dbc1
Compare
I've rebuilt the failed Windows build 31771 |
dtasev
approved these changes
Aug 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ISIS Team: LSS
Issue and pull requests managed by the LSS subteam at ISIS
Reflectometry
Issues and pull requests related to reflectometry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional unit tests to do with merging rows into the ISIS Reflectometry GUI. In particular, it tests the
mergeRowIntoGroup
function, which updates theReductionJobs
model with the merged row (if a merge is applicable).There is also some minor tidying to simplify the function interface and remove spurious warnings from existing tests.
To test:
Refs #26512
This does not require release notes because it concerns testing only
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.