Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muon analysis crash when using default grouping with no runs #29708

Merged
merged 3 commits into from
Oct 19, 2020

Conversation

AnthonyLim23
Copy link
Contributor

Description of work.

To test:

  1. Go to the grouping tab
  2. Press default
  3. It used to crash, you now get a pop up

Test 2:
Open muon analysis
Set instrument to EMU
Load some data
Change the instrument to MUSR
Go to grouping tab
Click default - crash

Fixes #29705.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

@AnthonyLim23 AnthonyLim23 added ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Added during Sprint Tasks that were added after initial sprint planning Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Patch Candidate Urgent issues that must be included in a patch following a release Reported By User Issues that were found or highlighted by a user/scientist labels Oct 12, 2020
@martyngigg martyngigg added this to the Release 5.1.1 milestone Oct 14, 2020
@Matt-Cumber Matt-Cumber self-assigned this Oct 14, 2020
Copy link
Contributor

@Matt-Cumber Matt-Cumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and it fixes the bug. Just one very minor comment

Co-authored-by: Matthew Cumber <matthew.cumber@stfc.ac.uk>
@martyngigg
Copy link
Member

Is it worth us trying to get this into the build tonight for testing?

@AnthonyLim23
Copy link
Contributor Author

I have already made a package and sent it to them

@martyngigg
Copy link
Member

Cool. Thanks.

@martyngigg martyngigg merged commit 236f4f0 into release-next Oct 19, 2020
@martyngigg martyngigg deleted the 29705_detBugMuon branch October 19, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added during Sprint Tasks that were added after initial sprint planning Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Patch Candidate Urgent issues that must be included in a patch following a release Reported By User Issues that were found or highlighted by a user/scientist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants