VESUVIO l1 and theta resolution routine #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanNixon
added
the
Indirect/Inelastic
| double xMin(DBL_MAX); | ||
| double xMax(DBL_MIN); | ||
| for(size_t i = 0; i < numHist; i++) { | ||
| const std::vector<double> x = ws->readX(i); |
There was a problem hiding this comment.
This would be better off as a const std::vector<double> &, so that the X values are not copied.
|
Tested with suggested data and everything appears to work correctly. However, it takes several minutes to run and only uses one core of my cpu. This could perform significantly better if allowed to use multiple threads, but that's a separate issue. |
eXeC64
added a commit
that referenced
this pull request
Jun 4, 2015
…olution VESUVIO l1 and theta resolution routine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12671
To test:
IP0005.datfile form unit test dataRelease notes change is here.