tests

mantidimaging/gui/windows/spectrum_viewer/test/model_test.py

@@ -11,7 +11,7 @@
 import numpy.testing as npt
 from parameterized import parameterized
 
-from mantidimaging.core.io.instrument_log import InstrumentLog, ShutterCount
+from mantidimaging.core.io.instrument_log import InstrumentLog, ShutterCount, ShutterCountColumn
 from mantidimaging.gui.windows.spectrum_viewer import SpectrumViewerWindowPresenter, SpectrumViewerWindowModel
 from mantidimaging.gui.windows.spectrum_viewer.model import SpecType, ErrorMode
 from mantidimaging.test_helpers.unit_test_helper import generate_images
@@ -56,7 +56,7 @@ def _set_normalise_stack(self, with_shuttercount=False):
         self.model.set_normalise_stack(normalise_stack)
         if with_shuttercount:
             mock_shuttercounts = mock.create_autospec(ShutterCount, source_file="")
-            mock_shuttercounts.get_column.return_value = np.arange(0, 10)
+            mock_shuttercounts.get_column.return_value = np.arange(0, 5)
             normalise_stack._shutter_count_file = mock_shuttercounts
         return normalise_stack
 
@@ -516,9 +516,24 @@ def test_save_rits_correct_transmision(self, mock_save_rits_roi):
     def test_get_stack_shuttercounts_returns_none_if_no_stack(self):
         self.assertEqual(self.model.get_stack_shuttercounts(stack=None), None)
 
-    def test_get_stack_shuttercount_returns_shuttercount_if_stack(self):
+    def test_get_stack_shuttercounts_returns_shutter_count_if_stack(self):
         stack, _ = self._set_sample_stack(with_tof=True, with_shuttercount=True)
         normalise_stack = self._set_normalise_stack(with_shuttercount=True)
 
-        self.assertEqual(self.model.get_stack_shuttercounts(stack), stack.shutter_count_file)
-        self.assertEqual(self.model.get_stack_shuttercounts(normalise_stack), normalise_stack.shutter_count_file)
+        self.assertTrue(
+            np.array_equal(self.model.get_stack_shuttercounts(stack),
+                           stack.shutter_count_file.get_column(ShutterCountColumn.SHUTTER_COUNT)))
+        self.assertTrue(
+            np.array_equal(self.model.get_stack_shuttercounts(normalise_stack),
+                           normalise_stack.shutter_count_file.get_column(ShutterCountColumn.SHUTTER_COUNT)))
+
+    def test_get_shuttercount_normalised_correction_parameter_returns_one_if_no_stack(self):
+        with mock.patch.object(self.model, "get_stack_shuttercounts") as mock_get_stack_shuttercounts:
+            mock_get_stack_shuttercounts.return_value = None
+            self.assertEqual(self.model.get_shuttercount_normalised_correction_parameter(), 1)
+
+    def test_get_shuttercount_normalised_correction_parameter_with_none_values(self):
+        self.model.get_stack_shuttercounts = mock.MagicMock(return_value=None)
+        expected_result = 1
+        result = self.model.get_shuttercount_normalised_correction_parameter()
+        self.assertEqual(result, expected_result)