-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@mantine/core] Slider: Show correct numeric values #2656
Conversation
It does now work correctly in the storybook – min is set to 1, but the user will still be able to go to 0 2022-10-11.18.00.22.mov |
@wes337 Are you planning to finish the work on this PR? |
Yes, I want to finish this. Sorry I’ve been a bad contributor lately — been busy with work. |
No worries, just checking that you haven't forgotten about it |
@rtivital This can be reviewed again |
Thanks! |
@wes337 this PR broke something:
Can you have a look? |
Yes, I’ll look into this |
The slider will now show the correct min/max numeric values.
Before
After
And if the min is a negative value:
Resolves #2444