Implement RevisionNotFound exception

mantisbt · Sep 17, 2011 · 6938b1d · 6938b1d
1 parent a556aa9
commit 6938b1d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/application/MantisBT/Exception/Issue/Revision/RevisionNotFound.php b/application/MantisBT/Exception/Issue/Revision/RevisionNotFound.php
@@ -0,0 +1,14 @@
+<?php
+namespace MantisBT\Exception\Issue\Revision;
+use MantisBT\Exception\ExceptionAbstract;
+
+require_api('lang_api.php');
+
+class RevisionNotFound extends ExceptionAbstract {
+	public function __construct($revisionID) {
+		$errorMessage = lang_get(ERROR_BUG_REVISION_NOT_FOUND, null, false);
+		$errorMessage = sprintf($errorMessage, $revisionID);
+		parent::__construct(ERROR_BUG_REVISION_NOT_FOUND, $errorMessage, null);
+		$this->responseCode = 400;
+	}
+}
diff --git a/application/core/bug_revision_api.php b/application/core/bug_revision_api.php
@@ -26,6 +26,8 @@
  * @uses database_api.php
  */
 
+use MantisBT\Exception\Issue\Revision\RevisionNotFound;
+
 require_api( 'constant_inc.php' );
 require_api( 'database_api.php' );
 
@@ -113,7 +115,7 @@ function bug_revision_get( $p_revision_id ) {
 
 	$t_row = db_fetch_array( $t_result );
 	if ( !$t_row ) {
-		trigger_error( ERROR_BUG_REVISION_NOT_FOUND, ERROR );
+		throw new RevisionNotFound( $p_revision_id );
 	}
 
 	return $t_row;
@@ -306,7 +308,7 @@ function bug_revision_like( $p_rev_id ) {
 	$t_row = db_fetch_array( $t_result );
 
 	if ( !$t_row ) {
-		trigger_error( ERROR_BUG_REVISION_NOT_FOUND, ERROR );
+		throw new RevisionNotFound( $p_rev_id );
 	}
 
 	$t_bug_id = $t_row['bug_id'];