Skip to content

Commit

Permalink
HTML Validation fixes
Browse files Browse the repository at this point in the history 
Use form id over name
fix CSS in manage config email page
  • Loading branch information
@mantis
mantis committed Sep 28, 2014
1 parent 6f00387 commit dc00c1d
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 16 deletions.
2 changes: 1 addition & 1 deletion admin/move_attachments_page.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ function get_attachment_stats( $p_file_type, $p_in_db ) {

<div align="center">

<form name="move_attachments_project_select" method="post" action="move_attachments.php">
<form id="move_attachments_project_select" method="post" action="move_attachments.php">
<table class="width50">
<tr>
<td class="form-title" colspan="2">
Expand Down
3 changes: 1 addition & 2 deletions bug_update_page.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,7 @@
?>
<br />
<div id="bug-update" class="form-container">

<form name="update_bug_form" method="post" action="bug_update.php">
<form id="update_bug_form" method="post" action="bug_update.php">
<?php echo form_security_field( 'bug_update' ); ?>
<table>
<thead>
Expand Down
2 changes: 1 addition & 1 deletion bugnote_add_inc.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<?php
collapse_open( 'bugnote_add', '', 'form-container' );
?>
<form name="bugnoteadd" method="post" action="bugnote_add.php">
<form id="bugnoteadd" method="post" action="bugnote_add.php">
<?php echo form_security_field( 'bugnote_add' ) ?>
<input type="hidden" name="bug_id" value="<?php echo $f_bug_id ?>" />
<table>
Expand Down
2 changes: 1 addition & 1 deletion css/default.css
View file
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ td.category, th.category { background-color: #c8c8e8; color: #000000; font-weig
td.category2, th.category2 { background-color: #c8c8e8; color: #000000; vertical-align : top; }
td.overdue { background-color: #ff0000; color: #000000; font-weight: bold; }
td.sticky-header { background-color: #999999; }
td.width30 { width: 30%; }
td.width30, th.width30 { width: 30%; }
td.col-1 { background-color: #d8d8d8; color: #000000; }
td.col-2 { background-color: #e8e8e8; color: #000000; }
td.form-title { background-color: #ffffff; color: #000000; font-weight: bold; text-align: left; }
Expand Down
8 changes: 4 additions & 4 deletions manage_config_email_page.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,9 @@ function get_section_begin_for_email( $p_section_name ) {
echo '<table>' . "\n";
echo ' <thead>' . "\n";
echo ' <tr>' . "\n";
echo ' <td class="form-title-caps" colspan="' . ( count( $t_access_levels ) + 7 ) . '">' . $p_section_name . '</td></tr>' . "\n";
echo ' <td class="form-title-caps" colspan="' . ( count( $t_access_levels ) + 5 ) . '">' . $p_section_name . '</td></tr>' . "\n";
echo ' <tr class="row-category2">' . "\n";
echo ' <th width="30%" rowspan="2">' . lang_get( 'message' ) . '</th>';
echo ' <th class="width30" rowspan="2">' . lang_get( 'message' ) . '</th>';
echo ' <th class="form-title" style="text-align:center" rowspan="2">&#160;' . lang_get( 'issue_reporter' ) . '&#160;</th>' . "\n";
echo ' <th class="form-title" style="text-align:center" rowspan="2">&#160;' . lang_get( 'issue_handler' ) . '&#160;</th>' . "\n";
echo ' <th class="form-title" style="text-align:center" rowspan="2">&#160;' . lang_get( 'users_monitoring_bug' ) . '&#160;</th>' . "\n";
Expand Down Expand Up @@ -312,7 +312,7 @@ function get_section_end_for_email() {
if( config_get( 'enable_email_notification' ) == ON ) {

if( $g_can_change_flags || $g_can_change_defaults ) {
echo "<form name=\"mail_config_action\" method=\"post\" action=\"manage_config_email_set.php\">\n";
echo '<form id="mail_config_action" method="post" action="manage_config_email_set.php">' . "\n";
echo form_security_field( 'manage_config_email_set' );
}

Expand Down Expand Up @@ -358,7 +358,7 @@ function get_section_end_for_email() {
echo "</form>\n";

echo '<div class="right">' . "\n";
echo '<form name="mail_config_action" method="post" action="manage_config_revert.php">' . "\n";
echo '<form id="mail_config_action" method="post" action="manage_config_revert.php">' . "\n";
echo form_security_field( 'manage_config_revert' ) . "\n";
echo '<input name="revert" type="hidden" value="notify_flags,default_notify_flags" />' . "\n";
echo '<input name="project" type="hidden" value="' . $t_project . '" />' . "\n";
Expand Down
4 changes: 2 additions & 2 deletions manage_config_work_threshold_page.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ function get_section_end() {
}
echo '<span class="color-global">' . lang_get( 'colour_global' ) . '</span></p>';

echo "<form name=\"mail_config_action\" method=\"post\" action=\"manage_config_work_threshold_set.php\">\n";
echo '<form id="mail_config_action" method="post" action="manage_config_work_threshold_set.php">' . "\n";
echo form_security_field( 'manage_config_work_threshold_set' );

# Issues
Expand Down Expand Up @@ -406,7 +406,7 @@ function get_section_end() {
echo '</form>' . "\n";

if( $t_show_submit && ( 0 < count( $g_overrides ) ) ) {
echo '<div class="right"><form name="threshold_config_action" method="post" action="manage_config_revert.php">' . "\n";
echo '<div class="right"><form id="threshold_config_action" method="post" action="manage_config_revert.php">' . "\n";
echo form_security_field( 'manage_config_revert' );
echo '<input name="revert" type="hidden" value="' . implode( ',', $g_overrides ) . '"></input>';
echo '<input name="project" type="hidden" value="' . $g_project_id . '"></input>';
Expand Down
4 changes: 2 additions & 2 deletions manage_config_workflow_page.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -417,7 +417,7 @@ function access_end() {
}
}

echo '<form name="workflow_config_action" method="post" action="manage_config_workflow_set.php">' . "\n";
echo '<form id="workflow_config_action" method="post" action="manage_config_workflow_set.php">' . "\n";
echo '<fieldset>';
echo form_security_field( 'manage_config_workflow_set' );
echo '</fieldset>';
Expand Down Expand Up @@ -490,7 +490,7 @@ function access_end() {
echo '</form>' . "\n";

if( 0 < count( $g_overrides ) ) {
echo '<div class="right"><form name="mail_config_action" method="post" action="manage_config_revert.php">' ."\n";
echo '<div class="right"><form id="mail_config_action" method="post" action="manage_config_revert.php">' ."\n";
echo '<fieldset>' . "\n";
echo form_security_field( 'manage_config_revert' );
echo '<input name="revert" type="hidden" value="' . implode( ',', $g_overrides ) . '" />';
Expand Down
2 changes: 1 addition & 1 deletion plugins/MantisGraph/pages/bug_graph_page.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
1 => plugin_lang_get( 'show_as_table' ),
);
?>
<form name="graph_form" method="post" action="<?php echo plugin_page( 'bug_graph_page.php' ); ?>">
<form id="graph_form" method="post" action="<?php echo plugin_page( 'bug_graph_page.php' ); ?>">
<table class="width100" cellspacing="1">

<tr>
Expand Down
2 changes: 1 addition & 1 deletion plugins/XmlImportExport/pages/import.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
?>

<div id="importexport-import-div" class="form-container">
<form name="file_upload" method="post" enctype="multipart/form-data" action="<?php echo plugin_page( 'import_action' )?>">
<form id="file_upload" method="post" enctype="multipart/form-data" action="<?php echo plugin_page( 'import_action' )?>">
<fieldset>
<legend>
<span>
Expand Down
2 changes: 1 addition & 1 deletion view_all_inc.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
}
?>
<br />
<form name="bug_action" method="get" action="bug_actiongroup_page.php">
<form id="bug_action" method="get" action="bug_actiongroup_page.php">
<?php # CSRF protection not required here - form does not result in modifications ?>
<table id="buglist" class="width100" cellspacing="1">
<thead>
Expand Down

0 comments on commit dc00c1d

Please sign in to comment.