CSS/HTML fixes for consistent display of mandatory fields #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an inconsistency in the class name used to flag mandatory fields. The fields use 'required' class to display a red asterisk next to the label, while the parent fieldset relied on 'has-required' to display the '* required' legend at the bottom of the form. This caused password fields in account_page.php (which are only required in specific contexts, e.g. when changing a new account's password after verification) not to be flagged with the red asterisk. We now consistently use 'required'. Fixes #20395
Remove hardcoded '*' with span, use CSS 'required' class on label instead.
Remove hardcoded '*' with span, use CSS 'required' class on label instead. Improve generated HTML for custom fields display.
Improve generated HTML for custom fields display, remove hardcoded '*' with span, use CSS 'required' class on label instead.
Refactor the code to use "1.3-style" layout with form-container div and fieldset, instead of html table. Use 'required' CSS class for custom fields display instead of hardcoded '*' with span.
Refactor the code to use "1.3-style" layout with form-container div and fieldset, instead of html table Use 'required' CSS class for mandatory fields display instead of hardcoded '*' with span.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started off as a quick fix for #20395, and expanded to a broader series of related fixes.
With this, we should hopefully have a consistent use of 'required' class for mandatory fields throughout the codebase.