Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS/HTML fixes for consistent display of mandatory fields #695

Merged
merged 7 commits into from Jan 1, 2016
Merged

CSS/HTML fixes for consistent display of mandatory fields #695

merged 7 commits into from Jan 1, 2016

Commits on Jan 1, 2016

  1. CSS class renamed from 'has-required' to 'required' 

    There was an inconsistency in the class name used to flag mandatory
fields. The fields use 'required' class to display a red asterisk next
to the label, while the parent fieldset relied on 'has-required' to
display the '* required' legend at the bottom of the form.

This caused password fields in account_page.php (which are only required
in specific contexts, e.g.  when changing a new account's password after
verification) not to be flagged with the red asterisk.

We now consistently use 'required'.

Fixes #20395
    @dregad
    dregad committed Jan 1, 2016
    Configuration menu
    Copy the full SHA
    892d350 View commit details
    Browse the repository at this point in the history

  2. CSS: consistency for 'required' color

    @dregad
    dregad committed Jan 1, 2016
    Configuration menu
    Copy the full SHA
    28fee5e View commit details
    Browse the repository at this point in the history

  3. CSS 'required': project documentation pages 

    Remove hardcoded '*' with span, use CSS 'required' class on label
instead.
    @dregad
    dregad committed Jan 1, 2016
    Configuration menu
    Copy the full SHA
    d078ce3 View commit details
    Browse the repository at this point in the history

  4. CSS 'required': bug report page 

    Remove hardcoded '*' with span, use CSS 'required' class on label
instead.

Improve generated HTML for custom fields display.
    @dregad
    dregad committed Jan 1, 2016
    Configuration menu
    Copy the full SHA
    629686a View commit details
    Browse the repository at this point in the history

  5. CSS 'required': bug update page 

    Improve generated HTML for custom fields display, remove hardcoded '*'
with span, use CSS 'required' class on label instead.
    @dregad
    dregad committed Jan 1, 2016
    Configuration menu
    Copy the full SHA
    61a559f View commit details
    Browse the repository at this point in the history

  6. HTML/CSS for bug change status page 

    Refactor the code to use "1.3-style" layout with form-container div and
fieldset, instead of html table.

Use 'required' CSS class for custom fields display instead of hardcoded
'*' with span.
    @dregad
    dregad committed Jan 1, 2016
    Configuration menu
    Copy the full SHA
    5c4035b View commit details
    Browse the repository at this point in the history

  7. HTML/CSS for account profile edit page 

    Refactor the code to use "1.3-style" layout with form-container div and
fieldset, instead of html table

Use 'required' CSS class for mandatory fields display instead of
hardcoded '*' with span.
    @dregad
    dregad committed Jan 1, 2016
    Configuration menu
    Copy the full SHA
    25695c7 View commit details
    Browse the repository at this point in the history