New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: add ethTxValue #89

Merged

Tri-stone merged 14 commits into release/v0.5.0 from bugfix/add-ethtxvalue

Feb 6, 2024

Contributor

abelliumnt commented Jan 17, 2024

No description provided.

openzeppelin-code bot commented Jan 17, 2024 •

edited

Loading

WIP: add ethTxValue

Generated at commit: 13fbe313b1c57b51710c7ea277ac01a5b5c2e5f0

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 1 0 11 25 39
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

For more details view the full report in OpenZeppelin Code Inspector

github-actions bot commented Jan 17, 2024

Encountered a total of 2 failing tests, 532 tests succeeded

3 similar comments

github-actions bot commented Jan 17, 2024

Encountered a total of 2 failing tests, 532 tests succeeded

github-actions bot commented Jan 17, 2024

Encountered a total of 2 failing tests, 532 tests succeeded

github-actions bot commented Jan 18, 2024

Encountered a total of 2 failing tests, 532 tests succeeded

github-actions bot commented Jan 18, 2024

Encountered a total of 14 failing tests, 520 tests succeeded

github-actions bot commented Jan 18, 2024

Encountered a total of 2 failing tests, 532 tests succeeded

github-actions bot commented Jan 18, 2024

Ran 109 test suites: 534 tests passed😊, 0 failed😂, 0 skipped (534 total tests)

abelliumnt force-pushed the bugfix/add-ethtxvalue branch from 502a2ef to b11f4b4 Compare

January 18, 2024 07:32

github-actions bot commented Jan 18, 2024

Ran 109 test suites: 534 tests passed😊, 0 failed😂, 0 skipped (534 total tests)

2 similar comments

github-actions bot commented Jan 18, 2024

Ran 109 test suites: 534 tests passed😊, 0 failed😂, 0 skipped (534 total tests)

github-actions bot commented Jan 18, 2024

Ran 109 test suites: 534 tests passed😊, 0 failed😂, 0 skipped (534 total tests)

github-actions bot commented Jan 18, 2024

Encountered a total of 1 failing tests, 533 tests succeeded

abelliumnt changed the title ~~WIP: add ethTxValue~~ R4R: add ethTxValue

abelliumnt requested review from byteflyfunny, Tri-stone, guoshijiang, lqS0317 and idyllsss

January 19, 2024 07:23

github-actions bot commented Jan 19, 2024

Ran 109 test suites: 534 tests passed😊, 0 failed😂, 0 skipped (534 total tests)

Contributor Author

abelliumnt commented Jan 19, 2024

Related op-geth PR: mantlenetworkio/op-geth#31

abelliumnt force-pushed the bugfix/add-ethtxvalue branch from 97f7db1 to c0e5c9a Compare

January 30, 2024 09:30

github-actions bot commented Jan 30, 2024

Ran 109 test suites: 534 tests passed😊, 0 failed😂, 0 skipped (534 total tests)

abelliumnt force-pushed the bugfix/add-ethtxvalue branch from c0e5c9a to bffb68b Compare

January 30, 2024 09:44

github-actions bot commented Jan 30, 2024

Ran 109 test suites: 534 tests passed😊, 0 failed😂, 0 skipped (534 total tests)

abelliumnt added 5 commits

February 1, 2024 19:45


          add ethTxValue

d8e71bb


          fix unit tests

b4f09c6


          fix unitests

95be76f


          bump deposite version

e11f7a8


          fix unitests

396fa0e

abelliumnt added 7 commits

February 1, 2024 19:46


          fix unittests

da73103


          fix tests

064626f


          update DepositEventVersion1

e6f3e9c


          update dependency

8839bb0


          fix wrong seq

736308b


          update dependency

c708931


          update bindings

5fd9f40

abelliumnt force-pushed the bugfix/add-ethtxvalue branch from bffb68b to 5fd9f40 Compare

February 1, 2024 11:51


          revert unnecessary changes

752e9bc

github-actions bot commented Feb 1, 2024

Ran 109 test suites: 534 tests passed😊, 0 failed😂, 0 skipped (534 total tests)

1 similar comment

github-actions bot commented Feb 1, 2024

Ran 109 test suites: 534 tests passed😊, 0 failed😂, 0 skipped (534 total tests)

Tri-stone previously approved these changes

View reviewed changes


          [R4R]-[go.mod]feat: update op-geth library

76959dd

Tri-stone dismissed their stale review via

76959dd

February 6, 2024 11:24

Tri-stone approved these changes

View reviewed changes

github-actions bot commented Feb 6, 2024

Ran 109 test suites: 534 tests passed😊, 0 failed😂, 0 skipped (534 total tests)

wwqicode-blkchain approved these changes

View reviewed changes

Tri-stone merged commit e29d360 into release/v0.5.0

1 of 3 checks passed

abelliumnt mentioned this pull request

R4R: Bump OptimismPortal Semver version #104

Merged

Tri-stone mentioned this pull request

[R4R]-feat: merge from release/v0.5.0 to develop #115

Merged

Tri-stone added a commit that referenced this pull request


          Merge pull request #115 from mantlenetworkio/release/v0.5.0

[R4R]-feat: merge from release/v0.5.0 to develop 
- R4R: add ethTxValue #89
- R4R: fix bug in ESTIMATION_ADDRESS #95
- R4R: forbid portal contract to call mnt token directly #98
- R4R: update op-geth library to v0.5.0-7 #107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Tri-stone Tri-stone approved these changes

wwqicode-blkchain wwqicode-blkchain approved these changes

byteflyfunny Awaiting requested review from byteflyfunny

guoshijiang Awaiting requested review from guoshijiang

lqS0317 Awaiting requested review from lqS0317

idyllsss Awaiting requested review from idyllsss

Labels

None yet