Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]:fix lock threshold validation #1227

Merged
merged 2 commits into from
Jul 2, 2023
Merged

[R4R]:fix lock threshold validation #1227

merged 2 commits into from
Jul 2, 2023

Conversation

byteflyfunny
Copy link
Collaborator

Goals of PR

Core changes:

  • Query the threshold value of the TSSGroupManager smart contract and verify if the value in the keygen request is correct.

Related Issues:

@byteflyfunny byteflyfunny changed the title fix lock threshold validation [R4R]:fix lock threshold validation Jul 2, 2023
wukongcheng
wukongcheng reviewed Jul 2, 2023
View reviewed changes
tss/manager/keygen.go Outdated Show resolved Hide resolved
wukongcheng
wukongcheng requested changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@wukongcheng wukongcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointer usage is required here.

@wukongcheng wukongcheng merged commit 87b659d into develop Jul 2, 2023
1 of 5 checks passed
@wukongcheng wukongcheng deleted the fix-lock-threshold-validation-new branch July 2, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wukongcheng wukongcheng wukongcheng approved these changes

@guoshijiang guoshijiang guoshijiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@byteflyfunny @wukongcheng @guoshijiang