fix: write errors to stderr (#26)

fix: write errors to stderr Co-authored-by: n3oney <neo@neoney.dev>
mantoni · Sep 22, 2023 · d76e925 · d76e925
1 parent b012b6b
commit d76e925
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 10 deletions.
diff --git a/lib/client.js b/lib/client.js
@@ -8,7 +8,7 @@ function write(chunk) {
 }
 
 function fail(err) {
-  out.write(`${err}\n`);
+  out.writeError(`${err}\n`);
 }
 
 function sendCommand(command, callback) {

diff --git a/lib/launcher.js b/lib/launcher.js
@@ -50,13 +50,13 @@ exports.launch = function (callback) {
   connect((err, socket) => {
     if (err) {
       if (process.exitCode) {
-        out.write(`${err}\n`);
+        out.writeError(`${err}\n`);
         return;
       }
       launch(callback);
     } else {
       socket.end();
-      out.write('Already running\n');
+      out.writeError('Already running\n');
     }
   });
 };
diff --git a/lib/out.js b/lib/out.js
@@ -3,3 +3,7 @@
 exports.write = function (message) {
   process.stdout.write(message);
 };
+
+exports.writeError = function (message) {
+  process.stderr.write(message);
+};
diff --git a/test/client-test.js b/test/client-test.js
@@ -30,6 +30,7 @@ describe('client', () => {
     socket = new EventEmitter();
     socket.end = sinon.fake();
     sinon.replace(out, 'write', sinon.fake());
+    sinon.replace(out, 'writeError', sinon.fake());
   });
 
   afterEach(() => {
@@ -41,7 +42,7 @@ describe('client', () => {
 
     client[method](...args);
 
-    assert.calledOnceWith(out.write, 'Not running\n');
+    assert.calledOnceWith(out.writeError, 'Not running\n');
     assert.isUndefined(process.exitCode);
   }
 
@@ -55,7 +56,7 @@ describe('client', () => {
 
     socket.emit('error', new Error());
 
-    assert.calledOnceWith(out.write, 'Could not connect\n');
+    assert.calledOnceWith(out.writeError, 'Could not connect\n');
     assert.equals(process.exitCode, 1);
   }
 
@@ -81,7 +82,7 @@ describe('client', () => {
       client.start();
       net.connect.firstCall.callback();
 
-      assert.calledOnceWith(out.write, 'Already running\n');
+      assert.calledOnceWith(out.writeError, 'Already running\n');
     });
 
   });
@@ -317,7 +318,7 @@ describe('client', () => {
 
       launcher.launch.firstCall.callback('Could not connect');
 
-      assert.calledOnceWith(out.write, 'Could not connect\n');
+      assert.calledOnceWith(out.writeError, 'Could not connect\n');
       assert.equals(process.exitCode, 1);
     });
 
@@ -330,7 +331,7 @@ describe('client', () => {
       socket.emit('error', new Error());
 
       refute.called(launcher.launch);
-      assert.calledOnceWith(out.write, 'Could not connect\n');
+      assert.calledOnceWith(out.writeError, 'Could not connect\n');
       assert.equals(process.exitCode, 1);
     });
 

diff --git a/test/launcher-test.js b/test/launcher-test.js
@@ -184,13 +184,13 @@ describe('launcher', () => {
 
   it('prints message and does not invoke callback if already running', () => {
     sinon.replace(portfile, 'read', sinon.fake.yields({ port: 7654, token }));
-    sinon.replace(out, 'write', sinon.fake());
+    sinon.replace(out, 'writeError', sinon.fake());
     const connect = sinon.replace(net, 'connect', sinon.fake.returns(socket));
 
     launcher.launch(callback);
     connect.firstCall.callback();
 
-    assert.calledOnceWith(out.write, 'Already running\n');
+    assert.calledOnceWith(out.writeError, 'Already running\n');
     refute.called(callback);
   });