Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: write errors to stderr #26

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Conversation

fsouza
Copy link
Contributor

@fsouza fsouza commented Sep 22, 2023

This is #24, with tests fixed.

Closes #19.
Closes #24.

Helps me with resolving fsouza/prettierd#611 馃榿

@fsouza
Copy link
Contributor Author

fsouza commented Sep 22, 2023

@mantoni thank you very much for core_d. When you have a chance, can you take a look at this PR?

@n3oney I hope you're OK with me picking your PR :)

@mantoni
Copy link
Owner

mantoni commented Sep 22, 2023

Nice! Thanks a lot 鉂わ笍

Would you say this is a breaking change that should be released as a new major? Or is minor fine?

@fsouza
Copy link
Contributor Author

fsouza commented Sep 22, 2023

That's a good point, it's probably safer to treat it as a breaking change: I can image that there are folks out there invoking eslint_d or prettierd and looking at the exit status to decide whether to treat stdout as error or not, which gets broken by this. What do you think?

@n3oney
Copy link
Contributor

n3oney commented Sep 22, 2023

That's a good point, it's probably safer to treat it as a breaking change: I can image that there are folks out there invoking eslint_d or prettierd and looking at the exit status to decide whether to treat stdout as error or not, which gets broken by this. What do you think?

Honestly I feel stupid now that I didn't even think of that when I was putting prettierd in my editor. Still have the damn thing replacing my entire code with errors when something's wrong with the syntax.......

So I must agree - this probably is a breaking change, since those people would now get empty error messages, if they did that.

@mantoni mantoni merged commit d76e925 into mantoni:master Sep 22, 2023
3 checks passed
@mantoni
Copy link
Owner

mantoni commented Sep 22, 2023

馃摝 Released in v6.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change error message output to stderr
3 participants