Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 support, add Python 3.10 support #318

Merged
merged 6 commits into from
Jan 24, 2022

Conversation

dhimmel
Copy link
Member

@dhimmel dhimmel commented Jan 19, 2022

See https://discuss.python.org/t/python-3-6-rides-into-the-sunset/12964:

Python 3.6 which officially reached end-of-life on 2021-12-23

@dhimmel
Copy link
Member Author

dhimmel commented Jan 19, 2022

Hitting the following issue when testing in pytest manubot/webpage/tests/test_webpage_command.py::test_webpage_command:

OpenTimestamp command returned nonzero code (-6).
>>> ots stamp webpage/v/testing/index.html

Only happening on macOS, not linux or windows.

Edit: tracked in #320. We're currently skipping the part of the test that checks for OTS success on macOS.

@dhimmel dhimmel merged commit e2896f7 into manubot:main Jan 24, 2022
@dhimmel dhimmel deleted the drop-py36 branch January 24, 2022 15:32
@agitter
Copy link
Member

agitter commented Jan 28, 2022

@dhimmel should we update this line when we change supported Python versions?

target-version = ['py36', 'py37', 'py38']

dhimmel added a commit to dhimmel/manubot that referenced this pull request Jan 28, 2022
@dhimmel
Copy link
Member Author

dhimmel commented Jan 28, 2022

should we update this line when we change supported Python versions?

Yes. Done in 3551dec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants