Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default CSS headers #293

Closed
Nebucatnetzer opened this issue Dec 22, 2019 · 3 comments · Fixed by #345
Closed

Default CSS headers #293

Nebucatnetzer opened this issue Dec 22, 2019 · 3 comments · Fixed by #345
Labels
frontend issues related to the HTML view and interactivity

Comments

@Nebucatnetzer
Copy link

I noticed that the headings sizes aren't correlating to the content.
E.g. an h5 heading is smaller than the caption of a table.
Since we should start with h2 the headers should be a bit bigger to not get so small when we use h5 as a level 4 heading.

@dhimmel
Copy link
Member

dhimmel commented Dec 26, 2019

Here is what github does:

Heading 1

Heading 2

Heading 3

Heading 4

Heading 5
Heading 6

So it seems that GitHub does get smaller and smaller headings, eventually smaller than regular text.

Since we should start with h2 the headers should be a bit bigger to not get so small when we use h5 as a level 4 heading.

I'm not sure I've ever had 4 levels of in-manuscript levels. When we're back from holidays, @vincerubinetti can perhaps suggest where to change the CSS to increase the level 5 heading size and see if he has any style suggestions.

@Nebucatnetzer
Copy link
Author

The 4 levels happen because we had to use the project management phases in the document, otherwise 3 levels would be enough.
Smaller than the body text might be okay, what I find strange is that they are smaller than the captions which are usually footnote size?

@dhimmel dhimmel added the frontend issues related to the HTML view and interactivity label Mar 5, 2020
@vincerubinetti
Copy link
Collaborator

Relevant:
https://stackoverflow.com/questions/55696808/why-do-h5-and-h6-have-smaller-font-sizes-than-p-in-most-user-agent-default

It is built into HTML/CSS itself, and is not related to Github specifically. It is a long-standing default styling, which I happen to think was a stupid choice. I'd be happy to break with precedence in this case.

dhimmel pushed a commit that referenced this issue Jun 5, 2020
merges #345

Enhancements related to Hypothes.is annotations plugin at build/plugins/hypothesis.html.
Adds button to load hypothesis plugin, rather than automatically loading it.
closes #281 

PDF build / print page view will no longer include annotations by default,
since hypothesis not loaded until activated.
closes #280

Fix overlap of hypothesis sidebar and table of contents plugin on small screens.
closes #306

Change default font sizes of h1 through h6 to be larger than base text size,
breaking with browser precedent
closes #293
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend issues related to the HTML view and interactivity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants