Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile UI Issue #306

Closed
ben-heil opened this issue Jan 30, 2020 · 2 comments · Fixed by #345
Closed

Mobile UI Issue #306

ben-heil opened this issue Jan 30, 2020 · 2 comments · Fixed by #345
Labels
frontend issues related to the HTML view and interactivity

Comments

@ben-heil
Copy link

When I open the page notes bar on the right side of the screen, the button to close the bar overlaps with the button to open the table of contents. As a result, closing the page notes/highlights bar opens the table of contents, which I then have to close to get back to reading.

Is it possible to disable the ToC button while the notes bar is expanded?
@agitter
Copy link
Member

agitter commented Jan 31, 2020

Thanks for reporting this. I'm able to reproduce it with the ready.mobi testing site. The expanded Hypothesis sidebar sits behind the table of contents button:
image

Would it help if the table of contents button was instead behind the sidebar? I don't know how to implement that. Any ideas @vincerubinetti?

@dhimmel
Copy link
Member

dhimmel commented Jan 31, 2020

Crossreferencing other hypothesis issues in #281. One idea we've talked about in #111 (comment) is not loading hypothesis by default, but having a button to activate it. I guess that wouldn't completely solve this issue, but could help.

@dhimmel dhimmel added the frontend issues related to the HTML view and interactivity label Mar 5, 2020
@dhimmel dhimmel mentioned this issue Jun 2, 2020
Closed
@vincerubinetti vincerubinetti mentioned this issue Jun 5, 2020
Merged
dhimmel pushed a commit that referenced this issue Jun 5, 2020
@vincerubinetti
webpage: improve Hypothes.is plugin & CSS heading sizes
d61267c 
merges #345

Enhancements related to Hypothes.is annotations plugin at build/plugins/hypothesis.html.
Adds button to load hypothesis plugin, rather than automatically loading it.
closes #281 

PDF build / print page view will no longer include annotations by default,
since hypothesis not loaded until activated.
closes #280

Fix overlap of hypothesis sidebar and table of contents plugin on small screens.
closes #306

Change default font sizes of h1 through h6 to be larger than base text size,
breaking with browser precedent
closes #293
@dhimmel dhimmel mentioned this issue Oct 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend issues related to the HTML view and interactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix some hypothesis issues
3 participants
@dhimmel @agitter @ben-heil