CSS improvements to github-pandoc.css #159
Conversation
webpage/github-pandoc.css
Outdated
| margin-left: 0.75in; | ||
| margin-right: 0.75in; | ||
| } | ||
| /* Remove margin, padding, border, etc. when printing; go right up to @page pargins. */ |
| @@ -262,7 +275,7 @@ sup { | |||
| } | |||
|
|
|||
| sup { | |||
| top: -0.5em; | |||
| top: -0.1em; | |||
There was a problem hiding this comment.
Will this fix the superscript appearance issues described at greenelab/meta-review#88 (comment)?
There was a problem hiding this comment.
No, that's just to make it look a little better (in my judgement). The real culprit of the problem was this:
| @@ -289,6 +302,25 @@ svg:not(:root) { | |||
| overflow: hidden; | |||
| } | |||
|
|
|||
| /** | |||
| * Hide hypothesis annotation toolbar, tooltip, etc. on print. | |||
| */ | |||
There was a problem hiding this comment.
Nice. It was annoying that printing would show the hypothesis toolbar. Does it also remove hypothesis highlights?
There was a problem hiding this comment.
No, I figured a user might want to retain those when printing? We should be easily able to remove that if you want though.
There was a problem hiding this comment.
No, I figured a user might want to retain those when printing?
Agreed
PR looks good to go pending review of the WeasyPrint PDF export. Let me know if you need help setting up the conda environment so |
This build is based on eb4cb3e. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/manubot-rootstock/builds/483107422 https://travis-ci.org/greenelab/manubot-rootstock/jobs/483107423 [ci skip] The full commit message that triggered this build is copied below: CSS improvements to github-pandoc.css Merges #159 When printing, hide hypothesis toolbar and fix page margins. Fix pandoc syntax highlighting quirk: long width code boxes overflow outside of container. Fix superscript size issue documented at greenelab/meta-review#88 (comment)
This build is based on eb4cb3e. This commit was created by the following Travis CI build and job: https://travis-ci.org/greenelab/manubot-rootstock/builds/483107422 https://travis-ci.org/greenelab/manubot-rootstock/jobs/483107423 [ci skip] The full commit message that triggered this build is copied below: CSS improvements to github-pandoc.css Merges #159 When printing, hide hypothesis toolbar and fix page margins. Fix pandoc syntax highlighting quirk: long width code boxes overflow outside of container. Fix superscript size issue documented at greenelab/meta-review#88 (comment)
Merges manubot/rootstock#159 When printing, hide hypothesis toolbar and fix page margins. Fix pandoc syntax highlighting quirk: long width code boxes overflow outside of container. Fix superscript size issue documented at greenelab/meta-review#88 (comment)
Merges manubot/rootstock#159 When printing, hide hypothesis toolbar and fix page margins. Fix pandoc syntax highlighting quirk: long width code boxes overflow outside of container. Fix superscript size issue documented at greenelab/meta-review#88 (comment)
0.75in