test/fix: Added test coverage and made fixed to getRoughCompassDirection #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exact matching resulting incorrect results
|
🎉 This PR is included in version 3.3.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, thought I chip in and add some test coverage. Along way I encountered what seemed to be a bug and fixed that. Please let me know of any changes that should made.
Add test coverage to the following files:
Made fixes to src/getRoughCompassDirection.ts:
What was happening here was the Regular expression would validate as true if string contained the value rather than matched exactly with value. For example,
/^NNE|NE|NNW|N$/would returnNforENEbecauseENEcontainsNE. The fix was to alter the regex so it performs a strict match rather than "contains".