Use useragent_ip instead of client_ip on Apache 2.4 #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although r->connection->client_ip is the 2.4 equivalent of r->connection->remote_ip in Apache 2.2, for mod_auth_pubtkt's use case it's more appropriate to check against r->useragent_ip, which is the IP of the actual user if there is a transparent load balancer or proxy between the user and the server.
For more details: https://httpd.apache.org/docs/2.4/developer/new_api_2_4.html