-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support recording timer types #23
Comments
This adds support for our existing timers. EPG based search timers are still missing. See #23
This adds support for our existing timers. EPG based search timers are still missing. See #23
No. Otherwise this issue would have been closed. The new timers makes recordings even worse. They are not visible in the EPG guide anymore and I doubt I can do anything about that. |
ok, thx for the info, maybe @ksooo can help with this. For testing, just contact me. |
I'm afraid you will need to debug Kodi yourself to learn why your timers do not show up correctly. Other add-ons have no problems with that. Sorry, I have no test environment for dvbviewer and pure brain debugging is sooooooooooo time consuming. ;-) |
Yeah, I understand that. I just wanted to rule out that this is by design. i.e. new timers must have the epg uid set. Can you point me to a file where I should start looking? I already looked at CFileItem but that basically leads me to everywhere :-) |
Btw I already looked at other PVRs as this is the first thing I do before asking for help. All PVRs I looked at make use of the epg uid field for non-manual timers. |
@popy2k14 You can download the new version for windows on https://ci.appveyor.com/project/manuelm/pvr-dvbviewer - I'll work on epg based timers after EDL as EDL is less work. |
@popy2k14 You can test auto timers now: https://ci.appveyor.com/project/manuelm/pvr-dvbviewer/build/master-132c1f3 |
@manuelm: have downloaded the x64 version of your plugin and when i am install it in my "KodiSetup-20180602-b5181d72-master-x64.exe" installation, kodi says: Cannot load addon. The log says:
|
I assume this is debug build related. I'll disable debug build and trigger a rebuild.
Yes, today. But you are using an older nightly and a compatible PVR. |
hm, ofc. rebuilding will pull in the new PVR API update as part of the dependencies.. :/ |
Please try those: https://ci.appveyor.com/project/manuelm/pvr-dvbviewer/build/test-65dc9a5 However before updating/installing the zip, you have to modify the file |
have now updated my kodi on my test machine to "KodiSetup-20180609-5da94d19-master-x64.exe" and installed your addon. The following i have tested:
Tumbs up for this and many thanks!!!! I have noticed a few drawbacks which would be fine gets sorted.
PS.: Just an idea, if these setting are not available in the pvr api, we could consider provide those globally with the addon settings. Dont get me wrong that's just suggestions to make it usable and get rid of creating auto timers with DMS :-) Really Really nice work you are doing to bringing the complete DMS features into kodi! pOpY |
Yes. In DMS there is actually no real connection between auto timers and timers after they are created. E.g. if you rename an autotimer the reference in the timers list does not get renamed. Regarding the wrong or missing default values: will check this next week. Regarding missing features: Kodi supports custom attributes but they are no multi select. So I'd have to provide 2**x different combinations which is not going to happen. Maybe @ksooo has an idea regarding this. Maybe an additional interface to provide an custom gui xml which gets appended and it's values pushed back to the PVR. |
No problem regarding the auto and child timers. Just wanted to say you my test results. I would say, this is just as it is :-) Thx, regarding missing default values, take your time. See my picture... pOpY |
Checked Priority is fixed with 3894af2
Global settings are the worst of all solutions. Won't do this. These 4 knobs would result in 16 different possible states. I think for now I won't add them at all until a better solution is available. |
However we could talk about changing the default values. e.g I don't have hard feelings about enabling "Additionally check against recording timers" all the time. "Additionally check against removed recordings" is already enabled per default. Regarding the remaining two knobs: I could add those as custom properties. Three different states seems ok. Especially as all three are related to each other. |
I cannot reproduce this. Here the default value gets set. And even if not it's a bug in the DMS. I do not touch the values at all.
Yes, but as already explained they are single select only. No multi select. So providing 4 different settings results in 16 different items/states. I won't do this. I'll go forward with always enabling "Additionally check against recording timers" and provide three different items/states for the two remaining deduplication settings. That's the best solution I can think of. And I won't do global settings. |
Those are defined by me. I'm mapping them to integer values in the specific range. The normal timer API supports setting the user default value by passing |
So I checked for Edit: Ok, I found a way to work around this. Might take a little longer to fix as it's more work/code then setting a magic value. |
hm, here it gets set to "Keine" but in settings i have one set (Post-Aufnahme). You said you dont even touch the "post recording task" values, maybe this is the issue?
from here: puenktchen/DVBViewerTVPlugin@bd8f43b Here a global string setting would be nice. ok, now ill got you regarding priority and the 4x knobs. Your explanation looks good to me also. |
As a first step we load certain default values from the backend and use them during auto timer creating. Later we should move the whole settings handling over. See #23
As a first step we load certain default values from the backend and use them during auto timer creation. Later we should move the whole settings handling over. See #23
@popy2k14 Please give https://ci.appveyor.com/project/manuelm/pvr-dvbviewer/build/master-8bcae0a a try. All remaining points should be fixed. Unless you find more bugs I'll push/publish the autotimers this weekend. |
@manuelm have tested the new version with the following results. The default "after" task will sadly not be set for me, see: I have looked into the code and seen that line:
should'nt that be "&after=" as seen on my above content (stolen from embys dvbd addon)? The option to prevent similar episode recordings works as it should. |
Check out the debug log to see what the PVR is sending.
No. You're mixing the autotimers/epg search and timers interface.
The PVR will use the default action defined in the DMS settings dialog. That's good enough. If you want to change the action you can do this using the webinterface or another tool. |
Heres the link to the api: http://en.dvbviewer.tv/wiki/Recording_Service_web_API#.2Ftasks.html.3Ftask |
@manuelm ill see, you are using /api/searchadd.htm rather than /api/timeradd.html. Where do you get the value for this parameter? Because in my case its empty.
|
you are getting the variable "m_recordingTask" with the call to "api/getconfigfile.html?file=config%%5Cservice.xml"the %5 should be a slash which would be in my case
When ill enter this ill get 404, i have to remove the second %
i'll get a correct answer. Could this be the issue? |
From
No. See I'll check this out myself. Haven't tested this at all. Just assumed I got it right. |
you are right, the string for the request is correct. |
Once again |
The default after recording task is working now, thanks a lot!
Ill must come back to this because there is no default setting in DMS for this, look here: |
There is. In the DMS settings UI. Not in it's webinterface. |
Pushed to upstream repo with 3.6.0 |
Actually the setting is also exported to the webinterface. It's on the right side of your screenshot. "Task after recording" or "Aufgabe nach Aufnahme" in german: Edit: However changing doesn't flush the file, so the PVR doesn't notice the setting unless you restart the DMS service + the PVR/Kodi. |
|
Where can those be set? |
I just read your posts again. I think we have talked passed each other. You are talking about defaults for deduplication whereas I'm talking about how to change the There are no defaults for deduplication. The first entry get's selected by Kodi. |
However I can change the default value if you want. I really don't care about this at all. |
yeah, now we are on the same train :-) For the deduplication: I am using this feature to prevent duplicates based on the subtitle, see the next picture. |
No. As I said the first value gets selected by Kodi. In general I tend to use the same defaults than the DMS. But I can change the default value to "Record if EPG title + subtitle differs" if you want. Personally, I think that's the better default value. |
ok, now ill got you. |
Fixed in 3.6.1. However during testing I noticed that the default value only gets selected if you create an autotimer from the EPG guide. Creating a new autotimer from the timers dialog still selects |
Any chance getting this backported to Krypton 2.4.x addon? Leia isn't released yet and i'm stuck on Krypton because of a special MVC build to have native 3D Blu-ray support (https://forum.kodi.tv/showthread.php?tid=266316). |
Looking at the forum thread there seems to be a Kodi Leia/18 version now. I'm not sure I'll have any time to look into this in the next couple of weeks. So I don't think a backport will happen from my side. |
Hi manuelm, |
The addon lacks on support of timer types, so you can select an series from epg record all upcoming shows off the same name.
Would be nice if this feature will be integrated.
The text was updated successfully, but these errors were encountered: