Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hspec-discover to PATH #28

Merged
merged 7 commits into from
Dec 23, 2020
Merged

Add hspec-discover to PATH #28

merged 7 commits into from
Dec 23, 2020

Conversation

manuphatak
Copy link
Owner

@manuphatak manuphatak commented Dec 23, 2020

HLS is not yet able to find project preprocessors ...

- https://github.com/haskell/haskell-language-server#preprocessor

In other words, vscode and the language server can't provide any useful features in the spec without hspec-discover being on the PATH.

@manuphatak manuphatak self-assigned this Dec 23, 2020
@manuphatak manuphatak added the repo Cleanup & improve the repo setup label Dec 23, 2020
@codecov
Copy link

codecov bot commented Dec 23, 2020

Codecov Report

Merging #28 (b6586b1) into main (571ee8b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #28   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          19       19           
  Lines         291      291           
  Branches       21       21           
=======================================
  Hits          279      279           
  Misses          6        6           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571ee8b...b6586b1. Read the comment docs.

@manuphatak manuphatak changed the title Dogfood build tools for HIE Add hspec-discover to PATH Dec 23, 2020
@manuphatak manuphatak merged commit 1559fce into main Dec 23, 2020
@manuphatak manuphatak deleted the create_bin_stack branch December 23, 2020 18:42
manuphatak added a commit that referenced this pull request Dec 23, 2020
* origin/main:
  Add hspec-discover to PATH (#28)
manuphatak added a commit that referenced this pull request Dec 26, 2020
* origin/main:
  Solve Day 18 (#31)
  Solve Day 17 (#30)
  Create Advent.Parser for shared parsers (#29)
  Solve Day 16 (#26)
  Add hspec-discover to PATH (#28)
manuphatak added a commit that referenced this pull request Jan 1, 2021
* origin/main:
  Solve Day 20 (#34)
  Solve Day 10 (#18)
  Harvest parseInts util (#33)
  Solve Day 18 (#31)
  Solve Day 17 (#30)
  Create Advent.Parser for shared parsers (#29)
  Solve Day 16 (#26)
  Add hspec-discover to PATH (#28)
manuphatak added a commit that referenced this pull request Jan 10, 2021
* origin/main:
  Update dependencies (#41)
  Remove hspec skip rules from hlint (#39)
  Add hlint rule (#37)
  Solve Day 21 (#35)
  Refactor: Use LANGUAGE TypeApplications (#36)
  Solve Day 12 (#21)
  Solve Day 20 (#34)
  Solve Day 10 (#18)
  Harvest parseInts util (#33)
  Solve Day 18 (#31)
  Solve Day 17 (#30)
  Create Advent.Parser for shared parsers (#29)
  Solve Day 16 (#26)
  Add hspec-discover to PATH (#28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo Cleanup & improve the repo setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant