Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Advent.Parser for shared parsers #29

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Create Advent.Parser for shared parsers #29

merged 1 commit into from
Dec 24, 2020

Conversation

manuphatak
Copy link
Owner

No description provided.

@manuphatak manuphatak added the refactor Harvest some reusable bits label Dec 24, 2020
@manuphatak manuphatak self-assigned this Dec 24, 2020
@codecov
Copy link

codecov bot commented Dec 24, 2020

Codecov Report

Merging #29 (cf3581f) into main (e15f230) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   95.48%   95.44%   -0.05%     
==========================================
  Files          22       23       +1     
  Lines         332      329       -3     
  Branches       21       21              
==========================================
- Hits          317      314       -3     
  Misses          9        9              
  Partials        6        6
Impacted Files Coverage Δ
src/Day02/Parser.hs 100.00% <ø> (ø)
src/Day08/Solution.hs 89.47% <ø> (-0.27%) ⬇️
src/Day14/Solution.hs 100.00% <ø> (ø)
src/Day16/Parser.hs 84.21% <ø> (ø)
src/Day16/Utils.hs 100.00% <ø> (ø)
src/Advent/Parser.hs 100.00% <100.00%> (ø)
src/Day13/Solution.hs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e15f230...cf3581f. Read the comment docs.

@manuphatak manuphatak marked this pull request as ready for review December 24, 2020 01:36
@manuphatak manuphatak merged commit 4724ec4 into main Dec 24, 2020
@manuphatak manuphatak deleted the refactor_int_parser branch December 24, 2020 01:37
manuphatak added a commit that referenced this pull request Dec 26, 2020
@manuphatak
Merge remote-tracking branch 'origin/main' into day_10
a93ea99 
* origin/main:
  Solve Day 18 (#31)
  Solve Day 17 (#30)
  Create Advent.Parser for shared parsers (#29)
  Solve Day 16 (#26)
  Add hspec-discover to PATH (#28)
manuphatak added a commit that referenced this pull request Jan 1, 2021
@manuphatak
Merge remote-tracking branch 'origin/main' into day_12
79a16f9 
* origin/main:
  Solve Day 20 (#34)
  Solve Day 10 (#18)
  Harvest parseInts util (#33)
  Solve Day 18 (#31)
  Solve Day 17 (#30)
  Create Advent.Parser for shared parsers (#29)
  Solve Day 16 (#26)
  Add hspec-discover to PATH (#28)
manuphatak added a commit that referenced this pull request Jan 10, 2021
@manuphatak
Merge remote-tracking branch 'origin/main' into day_15
6ec6bf7 
* origin/main:
  Update dependencies (#41)
  Remove hspec skip rules from hlint (#39)
  Add hlint rule (#37)
  Solve Day 21 (#35)
  Refactor: Use LANGUAGE TypeApplications (#36)
  Solve Day 12 (#21)
  Solve Day 20 (#34)
  Solve Day 10 (#18)
  Harvest parseInts util (#33)
  Solve Day 18 (#31)
  Solve Day 17 (#30)
  Create Advent.Parser for shared parsers (#29)
  Solve Day 16 (#26)
  Add hspec-discover to PATH (#28)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@manuphatak manuphatak

Labels
refactor Harvest some reusable bits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@manuphatak