Merge pull request quarkusio#38106 from yrodiere/fix-swallowed-sql-cl…

…ient-failures

Fix swallowed failures in Reactive SQL Client tests

extensions/reactive-mssql-client/deployment/src/test/java/io/quarkus/reactive/mssql/client/MSSQLPoolProducerTest.java

@@ -1,6 +1,5 @@
 package io.quarkus.reactive.mssql.client;
 
-import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionStage;
 
 import jakarta.enterprise.context.ApplicationScoped;
@@ -41,10 +40,8 @@ static class BeanUsingBareMSSQLClient {
         @Inject
         MSSQLPool mssqlClient;
 
-        public CompletionStage<Void> verify() {
-            CompletableFuture<Void> cf = new CompletableFuture<>();
-            mssqlClient.query("SELECT 1").execute(ar -> cf.complete(null));
-            return cf;
+        public CompletionStage<?> verify() {
+            return mssqlClient.query("SELECT 1").execute().toCompletionStage();
         }
     }
 
@@ -57,7 +54,6 @@ static class BeanUsingMutinyMSSQLClient {
         public CompletionStage<Void> verify() {
             return mssqlClient.query("SELECT 1").execute()
                     .onItem().ignore().andContinueWithNull()
-                    .onFailure().recoverWithItem((Void) null)
                     .subscribeAsCompletionStage();
         }
     }

extensions/reactive-mssql-client/deployment/src/test/resources/application-default-datasource.properties

@@ -1,2 +1,4 @@
 quarkus.datasource.db-kind=mssql
+quarkus.datasource.username=sa
+quarkus.datasource.password=yourStrong(!)Password
 quarkus.datasource.reactive.url=${reactive-mssql.url}

extensions/reactive-mysql-client/deployment/src/test/java/io/quarkus/reactive/mysql/client/MySQLPoolProducerTest.java

@@ -1,6 +1,5 @@
 package io.quarkus.reactive.mysql.client;
 
-import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionStage;
 
 import jakarta.enterprise.context.ApplicationScoped;
@@ -40,10 +39,8 @@ static class BeanUsingBareMySQLClient {
         @Inject
         MySQLPool mysqlClient;
 
-        public CompletionStage<Void> verify() {
-            CompletableFuture<Void> cf = new CompletableFuture<>();
-            mysqlClient.query("SELECT 1").execute(ar -> cf.complete(null));
-            return cf;
+        public CompletionStage<?> verify() {
+            return mysqlClient.query("SELECT 1").execute().toCompletionStage();
         }
     }
 
@@ -56,7 +53,6 @@ static class BeanUsingMutinyMySQLClient {
         public CompletionStage<Void> verify() {
             return mysqlClient.query("SELECT 1").execute()
                     .onItem().ignore().andContinueWithNull()
-                    .onFailure().recoverWithItem((Void) null)
                     .subscribeAsCompletionStage();
         }
     }

extensions/reactive-mysql-client/deployment/src/test/resources/application-default-datasource.properties

@@ -0,0 +1,4 @@
+quarkus.datasource.db-kind=mysql
+quarkus.datasource.username=hibernate_orm_test
+quarkus.datasource.password=hibernate_orm_test
+quarkus.datasource.reactive.url=${reactive-mysql.url}

extensions/reactive-oracle-client/deployment/src/test/java/io/quarkus/reactive/oracle/client/OraclePoolProducerTest.java

@@ -1,6 +1,5 @@
 package io.quarkus.reactive.oracle.client;
 
-import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionStage;
 
 import jakarta.enterprise.context.ApplicationScoped;
@@ -41,10 +40,8 @@ static class BeanUsingBareOracleClient {
         @Inject
         OraclePool oracleClient;
 
-        public CompletionStage<Void> verify() {
-            CompletableFuture<Void> cf = new CompletableFuture<>();
-            oracleClient.query("SELECT 1 FROM DUAL").execute(ar -> cf.complete(null));
-            return cf;
+        public CompletionStage<?> verify() {
+            return oracleClient.query("SELECT 1 FROM DUAL").execute().toCompletionStage();
         }
     }
 
@@ -57,7 +54,6 @@ static class BeanUsingMutinyOracleClient {
         public CompletionStage<Void> verify() {
             return oracleClient.query("SELECT 1 FROM DUAL").execute()
                     .onItem().ignore().andContinueWithNull()
-                    .onFailure().recoverWithItem((Void) null)
                     .subscribeAsCompletionStage();
         }
     }

extensions/reactive-oracle-client/deployment/src/test/resources/application-default-datasource.properties

@@ -1,2 +1,4 @@
 quarkus.datasource.db-kind=oracle
+quarkus.datasource.username=SYSTEM
+quarkus.datasource.password=hibernate_orm_test
 quarkus.datasource.reactive.url=${reactive-oracledb.url}

extensions/reactive-pg-client/deployment/src/test/java/io/quarkus/reactive/pg/client/PgPoolProducerTest.java

@@ -1,6 +1,5 @@
 package io.quarkus.reactive.pg.client;
 
-import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.CompletionStage;
 
 import jakarta.enterprise.context.ApplicationScoped;
@@ -41,10 +40,8 @@ static class BeanUsingBarePgClient {
         @Inject
         PgPool pgClient;
 
-        public CompletionStage<Void> verify() {
-            CompletableFuture<Void> cf = new CompletableFuture<>();
-            pgClient.query("SELECT 1").execute(ar -> cf.complete(null));
-            return cf;
+        public CompletionStage<?> verify() {
+            return pgClient.query("SELECT 1").execute().toCompletionStage();
         }
     }
 
@@ -57,7 +54,6 @@ static class BeanUsingMutinyPgClient {
         public CompletionStage<Void> verify() {
             return pgClient.query("SELECT 1").execute()
                     .onItem().ignore().andContinueWithNull()
-                    .onFailure().recoverWithItem(() -> null)
                     .subscribeAsCompletionStage();
         }
     }

extensions/reactive-pg-client/deployment/src/test/resources/application-default-datasource.properties

@@ -1,2 +1,4 @@
 quarkus.datasource.db-kind=postgresql
-quarkus.datasource.username=username-default
+quarkus.datasource.username=hibernate_orm_test
+quarkus.datasource.password=hibernate_orm_test
+quarkus.datasource.reactive.url=${reactive-postgres.url}