Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop requireing Devel::Cover #17

Closed
szabgab opened this issue Jan 31, 2016 · 7 comments
Closed

Stop requireing Devel::Cover #17

szabgab opened this issue Jan 31, 2016 · 7 comments

Comments

@szabgab
Copy link
Collaborator

szabgab commented Jan 31, 2016

I think most of the people who use Test::Critic don't need the functionality provided by Devel::Cover. IMHO Test::Strict should not depend on it and if the user invokes the all_cover_ok then it should be checked if Devel::Cover is installed.

@ribasushi
Copy link

+1

if the user invokes the all_cover_ok then it should be checked if Devel::Cover is installed

This is already the case. The only part missing is this being changed to "recommends" or somesuch.

Currently Devel::Cover does not build on blead, and as such drags this module with it.

dbsrgits-sync pushed a commit to Perl5/DBIx-Class that referenced this issue May 19, 2016
@ribasushi
Copy link

@manwar @szabgab ping: this is still a problem!

@manwar
Copy link
Owner

manwar commented Feb 20, 2018

Hi @ribasushi,

I will sort this out by end of play today.

Best Regards,
Mohammad S Anwar

@ribasushi
Copy link

The current solution is suboptimal. While it does solve my problem of reducing the dependency footrpint, it would not alert an end-user who requested all_cover_ok that D::C is not even available. Instead it emits a diag() ( which nobody is even able to see courtesy of how cpanm operates ) and SKIP_ALLs out of the test.

You should consider failing the test when D::C is not available, and documenting that it must now be specified explicitly as a dependency.

@ribasushi
Copy link

This seems to have been resolved, @szabgab I'd close

@jkeenan
Copy link

jkeenan commented Jul 29, 2024

This seems to have been resolved, @szabgab I'd close

@manwar, ^^

@manwar
Copy link
Owner

manwar commented Jul 29, 2024

Closing the issue as confirmed above.

@manwar manwar closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants