Semantic, accessibility, styling and DRY improvements #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piechowiakmichal
approved these changes
Oct 2, 2021
piechowiakmichal
approved these changes
Oct 2, 2021
piechowiakmichal
approved these changes
Oct 2, 2021
piechowiakmichal
approved these changes
Oct 2, 2021
piechowiakmichal
approved these changes
Oct 2, 2021
piechowiakmichal
approved these changes
Oct 2, 2021
piechowiakmichal
approved these changes
Oct 2, 2021
piechowiakmichal
approved these changes
Oct 2, 2021
|
All looks good! Merged, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved semantics and accessibility by removing improper element placements like more than one
headeron everyh2tag. Updated thesectionelements to have unique class names for screen readers. Reduced spacing on top of About Us page and added spacing to bottom to improve balance. Refactored some CSS code to follow the DRY principle (do not repeat yourself). Fixed any styling that I broke when making changes to the HTML.