Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query fails silently on parse errors #64

Closed
luntain opened this issue May 17, 2018 · 2 comments
Closed

query fails silently on parse errors #64

luntain opened this issue May 17, 2018 · 2 comments

Comments

@luntain
Copy link
Contributor

luntain commented May 17, 2018

I came across it when using (Tagged "time" Int) field. The query was returning no results even though printed and ran by hand was ok. It worked when I changed it to Tagged "time" UTCTime. But it broke agains when I set the precision to Second in query parameters. Now I know that was due to the precision being set to rfc3339 which returns human readable timestamps. Anyway, the bigger issue here is that parse errors are silent failures.

@maoe
Copy link
Owner

maoe commented May 18, 2018

This is because the QueryResults instance for that type uses parseResults which in turn uses the lenientDecoder.

It might be better to default to the strictDecoder, or maybe modify the method to take the decoder so that the user can choose whichever s/he like.

maoe pushed a commit that referenced this issue May 19, 2018
@maoe
Copy link
Owner

maoe commented May 19, 2018

I've fixed the issue in the feature/error-handling branch. Could you confirm if case_issue64 is the issue you described and check if it's fixed in this branch?

maoe pushed a commit that referenced this issue Sep 16, 2018
maoe pushed a commit that referenced this issue Mar 26, 2019
maoe pushed a commit that referenced this issue Jun 17, 2020
maoe pushed a commit that referenced this issue Jun 17, 2020
maoe pushed a commit that referenced this issue Jun 18, 2020
@maoe maoe closed this as completed in daaf149 Jun 19, 2020
maoe added a commit that referenced this issue Jun 19, 2020
v1.8.0

This release reworked the QueryResuls type class. There are some breaking changes:

* parseResults has been deprecated. QueryResults has now parseMeasurement method.
* Decoder has been monomorphized so that it can be used with lens. The original
  Decoder type has been renamed to SomeDecoder.
* QueryParams has now decoder field.
* parseResults and parseResultsWith had been using lenientDecoder and it caused
  some unintuitive behavior (#64, #66). Now they use strictDecoder instead.
* parseErrorObject now doesn't fail. It returns the error message of a response.
* parseQueryField which has been deprecated is now deleted.
* QueryResults instance for ShowSeries was broken. This is fixed.
* The constructor of Decoder, parseResultsWith, and parseResultsWithDecoder
  have been hidden from the top-level module. They're still available from
  Database.InfluxDB.JSON.

See #68 for how to migrate your code from v1.7.x to v1.8.x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants