Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak: CI & improvements #319

Merged
merged 5 commits into from
Mar 7, 2021
Merged

Flatpak: CI & improvements #319

merged 5 commits into from
Mar 7, 2021

Conversation

bilelmoussaoui
Copy link
Contributor

@bilelmoussaoui bilelmoussaoui commented Jan 10, 2021

Note: the ci can't run on the current repository until the PR is merged, you can see it running on my fork at https://github.com/bilelmoussaoui/drawing/runs/1677145655
The latest commit has to be reverted before merging

Edit: should be ready to go from my side

so that it builds the current repo content instead
@maoschanz maoschanz added feature request new features that don't exist at all packaging problems or question about the creation/maintenance of packages labels Jan 11, 2021
@maoschanz
Copy link
Owner

amazing (now i have to actually write tests lol)

while reverting the last commit, could you restore the empty options in the json manifest? they're never committed but i do put options in this array

@bilelmoussaoui
Copy link
Contributor Author

amazing (now i have to actually write tests lol)

you already have some to validate the desktop/metainfo files :P

while reverting the last commit, could you restore the empty options in the json manifest? they're never committed but i do put options in this array

My bad, done

the GNOME image comes with the sdk pre-installed and should reduce the CI time a bit
@maoschanz maoschanz mentioned this pull request Feb 9, 2021
19 tasks
@maoschanz maoschanz merged commit 34f6f4b into maoschanz:master Mar 7, 2021
@bilelmoussaoui bilelmoussaoui deleted the bilelmoussaoui/flatpak branch March 7, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request new features that don't exist at all packaging problems or question about the creation/maintenance of packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants