Added numpy vectorized version of haversine function #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added second version of haversine function that uses vectorized numpy functions (instead of scalar math library functions).
|
Released in 2.2.0. Sorry for the PR, I messed up with github, and commited on master. You appear as contributor though |
|
No problem. “haversine_vector” is just a minor modification of your code anyway. The vectorized version was useful in my work—I hope other people find it useful as well.
From: Julien Deniau <notifications@github.com>
Sent: Monday, January 6, 2020 5:52 PM
To: mapado/haversine <haversine@noreply.github.com>
Cc: Forgy, Charles <Forgyc@cna.org>; Author <author@noreply.github.com>
Subject: [External]Re: [mapado/haversine] Added numpy vectorized version of haversine function (#26)
Released in 2.2.0.
Sorry for the PR, I messed up with github, and commited on master. You appear as contributor though
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#26?email_source=notifications&email_token=AJ6TDD57MVIJIEYIFGDAAELQ4OYZBA5CNFSM4KBYD3J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIHB7PI#issuecomment-571350973>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJ6TDD4W75BG4HN7OWHPVFTQ4OYZBANCNFSM4KBYD3JQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a function "haversine_vector" that is merely the original "haversine" function with math library functions replaced with numpy functions in order to rapidly calculate the distance between two arrays of points.
Some quick "timeit" benchmarks indicate that for computing the haversine distance between two points, the vectorized version takes around 1.5 times longer than the regular version, whereas for computing the distance between two sets of 100 points each it's about 24 times faster.