Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added inver haversine functionality to the module #39

Merged
merged 3 commits into from
Aug 23, 2021
Merged

Added inver haversine functionality to the module #39

merged 3 commits into from
Aug 23, 2021

Conversation

CrapsJeroen
Copy link
Contributor

Based on open PR #19 and issue #29 I've added the inverse Haversine functionality for angles expressed in a radian angle.
Also added an Enum for the cardinal and intercardinal directions under Direction.

@jdeniau
Copy link
Member

jdeniau commented Aug 3, 2021

Hi !

Thank you for your contribution ! 👍
I will be on holiday for the next month. I will take a closer look at your PR when I come back. It does seems nice and clean, but I will avoid pushing a new release and break haversine 😄

@jdeniau
Copy link
Member

jdeniau commented Aug 3, 2021

For the record, and totally unrelated, the email you commit with seems to be unregistered with your github account (your avatar and your username are not set in your commit, see screenshot).

image

@CrapsJeroen
Copy link
Contributor Author

Hi !

Thank you for your contribution ! 👍
I will be on holiday for the next month. I will take a closer look at your PR when I come back. It does seems nice and clean, but I will avoid pushing a new release and break haversine 😄

I completely agree, enjoy your vacation!

For the record, and totally unrelated, the email you commit with seems to be unregistered with your github account (your avatar and your username are not set in your commit, see screenshot).

image

Thanks for bringing it to my attention. 🙏

@jdeniau jdeniau merged commit cc57838 into mapado:master Aug 23, 2021
@jdeniau
Copy link
Member

jdeniau commented Aug 23, 2021

Thanks @CrapsJeroen !
I will release that with #40 tonight or tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants