Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/load wms get min on null #585

Merged
merged 4 commits into from
Jul 27, 2017

Conversation

DavidPatzke
Copy link
Contributor

Hotfix for WMS with Scale fails to load #584

…t is available

If a parent was available the scale of this parent was returned instead of the function call to getScaleRecursive. Other function expexcted a MinMax as return type, also the tree structur could not be resolve if the level was deeper then 2
Copy link
Contributor

@AxxL AxxL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test ok

@werrolf
Copy link
Contributor

werrolf commented Jul 27, 2017

getScaleRecursive does not return anything if (local) scale is an object with min and max set and the instance has no parent to recurse to.

I.e. missing else return $scale on this if:

if ((!$hasMin || !$hasMax) && $parent) {

@eSlider
Copy link
Collaborator

eSlider commented Jul 27, 2017

@LazerTiberius, are you core with @wg-rolf?
@wg-rolf, can I merge this?

@eSlider eSlider added the WIP label Jul 27, 2017
@werrolf werrolf merged commit 67ec227 into release/3.0.6 Jul 27, 2017
@werrolf werrolf deleted the hotfix/load-WMS-getMin-on-null branch July 27, 2017 11:29
@rschwammborn rschwammborn removed the WIP label Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants