Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Commit

Permalink
Releasing nits
Browse files Browse the repository at this point in the history
Summary: Small improvements to releasing docs and script.

Test Plan: Manual

Reviewers: schrockn, alangenfeld, nate, prha, themissinghlink

Reviewed By: nate

Differential Revision: https://dagster.phacility.com/D1511
  • Loading branch information
mgasner committed Dec 2, 2019
1 parent c3994b5 commit 86f75f7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,8 @@ It's also prudent to release from a fresh virtualenv.
7. Check that the ReadTheDocs build was successful at
[https://readthedocs.org/projects/dagster/builds/](https://readthedocs.org/projects/dagster/builds/).

8. Publish the new version to PyPI.
8. Publish the new version to PyPI. If something goes wrong during this stage, you will probably
have to roll forwards to a new release, since there is no way to delete files from PyPI.

python bin/publish.py publish

Expand Down
8 changes: 4 additions & 4 deletions bin/publish.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,11 @@ def check_for_cruft(autoclean):
'Found potentially crufty directories:\n'
' {found_cruft}\n'
'***We strongly recommend releasing from a fresh git clone!***\n'
'Automatically remove these directories and continue? (Y/n)'.format(
'Automatically remove these directories and continue? (y/N)'.format(
found_cruft='\n '.join(found_cruft)
)
)
if wipeout == 'Y':
if wipeout == 'y' or wipeout == 'Y':
for cruft_dir in found_cruft:
subprocess.check_output(['rm', '-rfv', cruft_dir])
else:
Expand All @@ -474,11 +474,11 @@ def check_for_cruft(autoclean):
wipeout = input(
'Found {n_files} .pyc files.\n'
'We strongly recommend releasing from a fresh git clone!\n'
'Automatically remove these files and continue? (Y/n)'.format(
'Automatically remove these files and continue? (y/N)'.format(
n_files=len(found_pyc_files)
)
)
if wipeout == 'Y':
if wipeout == 'y' or wipeout == 'Y':
for file_ in found_pyc_files:
os.unlink(file_)
else:
Expand Down

0 comments on commit 86f75f7

Please sign in to comment.