This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
[search] polyfill search component to catch errors #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@katydecorah I tested this in /ios-sdk and it works as expected on npm start
. I get the following error when running npm run build
:
../dr-ui/pkg/back-to-top-button/index.js
Module build failed: ReferenceError: Unknown plugin "babel-plugin-transform-react-remove-prop-types" specified in "base" at 4, attempted to resolve relative to "/path/to/folder/dr-ui/pkg/back-to-top-button"
at Array.map (<anonymous>)
@colleenmcginnis looks like adding |
colleenmcginnis
approved these changes
Aug 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I retested this with the most recent changes and the build works as expected!
* master: [BackToTopButton] use `window.scroll(x-coord, y-coord)` (#167)
katydecorah
pushed a commit
that referenced
this pull request
Aug 12, 2019
katydecorah
pushed a commit
that referenced
this pull request
Aug 16, 2019
* master: (24 commits) 0.20.1 Prepare 0.20.1 0.20.0 Prepare 0.20.0 Prevent src/components/syntax-highlighters from being adding to pkg Update WarningImage in GLWrapper Update CHANGELOG.md Add syntax highlighting functions (#172) Add `GLWrapper` and `DemoIframe` components. (#166) compress svg update *-image themes and clean up svg, make IE11 friendly, set default `size` & make it a number [babel] Add babel config to helpers and plugins, add eslint plugins (#164) [Search] Enable babel polyfill on `Search` component (#165) [BackToTopButton] use `window.scroll(x-coord, y-coord)` (#167) Create a note "flavor" for new products or features (#162) [docs] Update webhook staging urls (#161) 0.19.3 Update CHANGELOG.md [Note] replace Object.assign with a function (#159) 0.19.2 ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing Sentry errors, I noticed that the search component is throwing errors in older browser versions like Firefox 44.
I built this PR locally and tested on /geographic-analytics:
IE 11 works
Firefox 44 works (The search component works , too. I'm not concerned about that weird icon positioning since it doesn't appear in the latest versions of Firefox.)
You can test this PR by:
"@mapbox/dr-ui": "file:/Users/katydecorah/Documents/GitHub/dr-ui/pkg",