This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Add aria-label to BackToTopButton #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 8, 2020 11:49
katydecorah
pushed a commit
that referenced
this pull request
Jul 8, 2020
* main: Add aria-label to BackToTopButton (#290)
katydecorah
pushed a commit
that referenced
this pull request
Jul 8, 2020
katydecorah
pushed a commit
that referenced
this pull request
Jul 8, 2020
katydecorah
pushed a commit
that referenced
this pull request
Jul 8, 2020
katydecorah
pushed a commit
that referenced
this pull request
Jul 8, 2020
* update sentry; set peerDependency * Update CHANGELOG.md * pin the peer dependency version * add test to make sure peerDep matches dep * Update react, react-dom, prop-types, react-test-renderer; Make react and react-dom peerDeps * add mr-ui and mbx-assembly as peerDeps * Update CHANGELOG.md * Update peer-deps.test.js * Merge branch 'main' into peer-deps * main: Remove unused highlight.js and util function (#305) Add aria-label to BackToTopButton (#290) Add the catalog site (#137) Delete dependabot.yml Only direct dependencies Create dependabot.yml (#296) Update Travis bad * Merge branch 'main' into peer-deps * main: Remove unused highlight.js and util function (#305) Add aria-label to BackToTopButton (#290) Add the catalog site (#137) Delete dependabot.yml Only direct dependencies Create dependabot.yml (#296) Update Travis bad * Update sentry * Update package-lock.json
katydecorah
pushed a commit
that referenced
this pull request
Jul 10, 2020
* main: (27 commits) Add Changelog to catalog site 0.29.2 Prepare 0.29.2 Update devDependencies, create jest-setup.js (#311) Set peerDependencies to keep frontend libraries in sync (#292) Remove unused highlight.js and util function (#305) Add aria-label to BackToTopButton (#290) Add the catalog site (#137) Delete dependabot.yml Only direct dependencies Create dependabot.yml (#296) Update Travis bad Update devDependencies (#294) 0.29.1 Update CHANGELOG.md Remove `limiter` from Topbar (#282) 0.29.0 Prepare 0.29.0 Allow Kotlin-only activities (#278) 0.28.0 ...
katydecorah
pushed a commit
that referenced
this pull request
Jul 14, 2020
* Add AnalyticsShell component * Update Sentry * Make `env()` function; add tests; use env() in Feedback * Documentation * Merge branch 'layouts-main' into layouts-analytics-shell * layouts-main: Add Changelog to catalog site 0.29.2 Prepare 0.29.2 Update devDependencies, create jest-setup.js (#311) Set peerDependencies to keep frontend libraries in sync (#292) Remove unused highlight.js and util function (#305) Add aria-label to BackToTopButton (#290) * Update package-lock.json * add sentry and web-analytics config tests * Update CHANGELOG.md
katydecorah
pushed a commit
that referenced
this pull request
Aug 26, 2020
* Update CHANGELOG.md * Remove PageLayout testCases from other components (#314) * [layouts] Add AnalyticsShell component (#307) * Add AnalyticsShell component * Update Sentry * Make `env()` function; add tests; use env() in Feedback * Documentation * Merge branch 'layouts-main' into layouts-analytics-shell * layouts-main: Add Changelog to catalog site 0.29.2 Prepare 0.29.2 Update devDependencies, create jest-setup.js (#311) Set peerDependencies to keep frontend libraries in sync (#292) Remove unused highlight.js and util function (#305) Add aria-label to BackToTopButton (#290) * Update package-lock.json * add sentry and web-analytics config tests * Update CHANGELOG.md * [layouts] Add batfish helpers (#310) * Add batfish helpers * use helpers * Enable appending of data * accept `topic` string or `topics` array * Create batfish helpers catalog page * Revert appending topic data * Add live examples * Remove dropdown option (this will be a PageLayout prop) * Update package.json * Update package.json * add links * Update CHANGELOG.md * 🔧 remove markdown from topic descriptions * Revert "🔧 remove markdown from topic descriptions" This reverts commit d41f906. * Set ignore files in babelc config * Revert "Set ignore files in babelc config" This reverts commit 68f143a. * 🔧 Rebuild fixture data from catalog site * Add header-image to test-cases-app * Update batfish.config.js to sync data to fixtures * Exclude helpers tests files from the package; update babel * Reorder tests * Add remark-linters to assert catalog * Add copyeditor to test catalog pages * Update remark-lint-mapbox; add products * Add @mapbox/rehype-prism (for catalog) * join topics and helpers in index file for easier importing * Update package-lock.json * [layouts] Updates PageLayout to be main controller for layouts (#309) * Add layouts to PageLayout comonent * Remove PageLayout from other components (now redundant) * Add examples for each layout * Fix catalog site * New configuration model * Documentation * Allow image paths in cards; enable `fullWidthCards` from frontMatter * Add unProse and noShellHeaderBuffer options * Add BackToTopButton * Wrap ErrorBoundary around contents of PageLayout * documentation * Reorganize; add `customSidebar` prop * Wrap ErrorBoundary around each major section * Update index.md * Remove context functions (will follow up in another PR) * Add tabListAppend prop * Update CHANGELOG.md * move CustomSidebar into sticky * clean up catalog site * Update page-layout.test.js.snap * fix column sizing * fix tabListAppend * add `heading` prop for dynamic headings * add `sidebarTitle` prop * add back append option for buildTopics * update snapshots; fix test * Clear the mobile sticky nav * Better handling of dynamic navTabs; fix ProductMenu homePage url * Pass section tag to navigation * Revert ":wrench: remove markdown from topic descriptions" This reverts commit d41f906. * Add sortArr argument to batfish-helpers/topics; document * add hideCardDescription and hideCardLanguage frontMatter props * Rebuild fixtures/snapshots * Add guides section to catalog * Update fixtures/snapshots * documentation! * Update navigation.test.js.snap * Update fixtures/snapshots * Update fixtures/snapshots * Reduce changes * Clean up * Disable generated file * Update snapshots * Reduce changes * Add products * Documentation * documentation * Update documentation * v1.0.0-layouts.0 * v1.0.0-layouts.1 * Add back missing scroll classes * Remove extra padding * Fix snapshot * Handle single topic in sortingArr * Fix issue where sectioned navigation links were not getting marked active * Documentation * Documentation * Documentation * if topBarSticker is turned off (false), set Stickey topValue to 0 * Apply suggestions from code review Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> * Wrap ProductMenu and PageLayout in backtics * Clean up * Rename basic.js to page.js * add Multi-structured sites guide; make terms consistent (multi-structured) * Rework "Top level navigation" section to "Navigation bar" and expand on the concept * Better distinguish navOrder and order; document order * Clean up * Add links * Update CHANGELOG.md * Apply suggestions from code review Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> * [layouts] Add splitPage Batfish selector (#317) * Add layouts to PageLayout comonent * Remove PageLayout from other components (now redundant) * Add examples for each layout * Fix catalog site * New configuration model * Documentation * Allow image paths in cards; enable `fullWidthCards` from frontMatter * Add unProse and noShellHeaderBuffer options * Add BackToTopButton * Wrap ErrorBoundary around contents of PageLayout * documentation * Reorganize; add `customSidebar` prop * Wrap ErrorBoundary around each major section * Update index.md * Remove context functions (will follow up in another PR) * Add tabListAppend prop * Update CHANGELOG.md * move CustomSidebar into sticky * clean up catalog site * Update page-layout.test.js.snap * fix column sizing * fix tabListAppend * add `heading` prop for dynamic headings * add `sidebarTitle` prop * add back append option for buildTopics * update snapshots; fix test * Add splitPage batfish function * Update snapshots * fix snapshot paths * Add `hideFromNav` option * Exclude batfish 404 page * only set tag for h2 * Clear the mobile sticky nav * Update package-lock.json * Better handling of dynamic navTabs; fix ProductMenu homePage url * Pass section tag to navigation * Revert ":wrench: remove markdown from topic descriptions" This reverts commit d41f906. * Add sortArr argument to batfish-helpers/topics; document * add hideCardDescription and hideCardLanguage frontMatter props * Handle `products` * Update guides * Rebuild fixtures/snapshots * Update fixtures/snapshots * Add guides section to catalog * Update fixtures/snapshots * Documentation * Add tag debugger page * Update fixtures/snapshots * Update fixtures/snapshots * documentation! * Update navigation.test.js.snap * Update fixtures/snapshots * Update fixtures/snapshots * Reduce changes * Update fixtures/snapshots * Apply suggestions from code review Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> * Add SplitPage component; update documentation * Add links to all pages using split-pages * add `why` to redirects section * Add note about heading order * Clean up * Clean up * Add back removed section * Reduce changes * Disable generated file * Update snapshots * Reduce changes * Update fixtures * Add products * Copyedits * copyedits * Documentation * documentation * Update documentation * v1.0.0-layouts.0 * v1.0.0-layouts.1 * Apply suggestions from code review Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> * Merge branch 'layouts-page-layout' into layouts-batfish-sections * layouts-page-layout: v1.0.0-layouts.1 join topics and helpers in index file for easier importing v1.0.0-layouts.0 Update documentation * Tighten up language around partial files and page * Remove products, services, platforms, contenttype for splitPage function (it's covered elsewhere) * Clean up * v1.0.0-layouts.2 * Clean up depenencies * v1.0.0-layouts.3 * Add back missing scroll classes * v1.0.0-layouts.4 * Remove extra padding * v1.0.0-layouts.5 * Fix snapshot * Handle single topic in sortingArr * v1.0.0-layouts.6 * Fix issue where sectioned navigation links were not getting marked active * v1.0.0-layouts.7 * Documentation * Documentation * Documentation * if topBarSticker is turned off (false), set Stickey topValue to 0 * v1.0.0-layouts.8 * [layouts] Get user obj from inside feedback component (#324) * Get user from inside Feedback component * v1.0.0-layouts.9 * Update test cases * Update CHANGELOG.md * [layouts] Fix sidebar height when topbar is not sticky (#325) * If topbar sticker is not sticky, make sidebar go full height * v1.0.0-layouts.10 * Reduce changes * Make sure navTabs has a length before displaying Tablist * v1.0.0-layouts.11 * Sort accordion pages * v1.0.0-layouts.12 * Apply suggestions from code review Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> * Wrap ProductMenu and PageLayout in backtics * Clean up * Rename basic.js to page.js * add Multi-structured sites guide; make terms consistent (multi-structured) * Rework "Top level navigation" section to "Navigation bar" and expand on the concept * Better distinguish navOrder and order; document order * Clean up * Add links * Update CHANGELOG.md * Apply suggestions from code review Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com> * Update packages with security vulnerabilities * Update CHANGELOG.md * v1.0.0-layouts.13 * Hide page sidebar on mobile * v1.0.0-layouts.14 * Always add mt to pages (not using accordion layout) * v1.0.0-layouts.15 * Adjust mt to account for accordion * v1.0.0-layouts.16 * Update CHANGELOG.md * Create mbxMetadata prop and set `window.mbxMetadata` in AnalyticsShell * v1.0.0-layouts.17 * Fix defaultProps * v1.0.0-layouts.18 * Adjust image thumbnail * v1.0.0-layouts.19 * Update mbx-assembly * v1.0.0-layouts.20 * Sort accordion alphabetically then by order * v1.0.0-layouts.21 * Add test case; improve accordion sorting * v1.0.0-layouts.22 * Add icon to accordion * v1.0.0-layouts.23 * Update titleGenerator to not push "Overview" to meta title * v1.0.0-layouts.24 * Add `cardColSize` prop to `CardContainer` to adjust size of cards * Pass props to Search and Feedback components * v1.0.0-layouts.25 * Fix props * Update dependencies * Add passthrough props for Search and Feedback * Clean up catalog * Update deps Co-authored-by: Colleen McGinnis <colleen.mcginnis@mapbox.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an aria-label to
BackToTopButton.Fixes #283
🐌
How to test