This repository has been archived by the owner on Jun 12, 2024. It is now read-only.
Add LevelIndicator component #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtheclark
approved these changes
Sep 4, 2018
| title: 'This is a full-length title', | ||
| path: 'url', | ||
| description: "Here's a reasonable length for a description.", | ||
| level: <LevelIndicator level={2} />, |
There was a problem hiding this comment.
This is one possibility for the interface; another would be to pass the level number directly. Curious why you chose to pass a React element instead of the level number? Do you think we may want to pass some other element in the future?
There was a problem hiding this comment.
Yea it's probably safe to just pass the level number.
| let squareColor = ''; | ||
| num > this.props.level | ||
| ? (squareColor = 'gray-light') | ||
| : (squareColor = levelColor); |
There was a problem hiding this comment.
This could be combined into one expression:
const squareColor = num > props.level ? 'gray-light' : levelColor;| className={`inline-block w6 bg-${squareColor} align-middle mr3`} | ||
| /> | ||
| ); | ||
| }); |
There was a problem hiding this comment.
This is a great use case for .map()! When you're taking one array (which should probably be Object.keys(levels)?) and transforming every item into another corresponding item in a new array (e.g. a React element), .map() is what you're looking for.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
1️⃣ Adds a new
LevelIndicatorcomponent based on the work done in /help (ty @danswick).2️⃣ Adds optional
levelandlanguageprops toCard(to be used for /help tutorials).Closes #53