Skip to content
This repository has been archived by the owner on Jun 12, 2024. It is now read-only.

adds window.scroll() to BackToTopButton #80

Merged
merged 3 commits into from
Dec 18, 2018
Merged

Conversation

katydecorah
Copy link
Contributor

fixes #76, by adding window.scroll() and keeping document.documentElement.scrollTop as a fallback since the former doesn't have complete browser support

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

Katy DeCorah added 2 commits December 18, 2018 12:18
* master:
  cleans up styles to allow `NavigationDropdown` to appear on iOS (#79)
@katydecorah katydecorah merged commit d9c1e1d into master Dec 18, 2018
@katydecorah katydecorah deleted the back-top-fix-ios branch December 18, 2018 17:20
katydecorah pushed a commit that referenced this pull request Dec 18, 2018
* master:
  adds `window.scroll()` to `BackToTopButton` (#80)
  cleans up styles to allow `NavigationDropdown` to appear on iOS (#79)
katydecorah pushed a commit that referenced this pull request Dec 21, 2018
* master:
  Prepare 0.0.12
  adds borderRadius; makes text color AA accessible (#78)
  adds `window.scroll()` to `BackToTopButton` (#80)
  cleans up styles to allow `NavigationDropdown` to appear on iOS (#79)
  Prepare 0.0.11 release
  Prepare 0.0.10 release
  move to new labs subdomain
katydecorah pushed a commit that referenced this pull request Jan 4, 2019
* master:
  Prepare 0.0.13
  [NavigationAccordion] collapses subitems when not selected and adds active state (#66)
  Prepare 0.0.12
  adds borderRadius; makes text color AA accessible (#78)
  adds `window.scroll()` to `BackToTopButton` (#80)
  cleans up styles to allow `NavigationDropdown` to appear on iOS (#79)
  Prepare 0.0.11 release
  Prepare 0.0.10 release
  move to new labs subdomain
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BackToTopButton not working on iOS
2 participants