-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic Types and Header Only #27
Comments
FWIW, we are already using this as a header-only library in Mapbox GL: #24 |
@kkaefer I would prefer to simply make it |
The drawback to making it header only is that it then requires the downstream library to depend on and provide rapidjson. May I ask why you want support for coordinate types other than |
@jfirebaugh I would like to use |
While exploring this library, I noticed two things that I would like to change -- but might be viewed as larger changes to the library.
First, I would like to make the library more generic such that it would output all
geometry<T>
types rather then justgeometry<double>
. As part of these changes I would like to also make the library header only -- we could get away with not doing this and simply defining the types specifically outside the impl file, but I could prefer it to simply be header only and if there are compile time issues let the implementing library solve this problem by encapsulating the use of the library./cc @jfirebaugh @kkaefer
The text was updated successfully, but these errors were encountered: