Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled templates by geometry type #28

Closed
wants to merge 6 commits into from
Closed

Conversation

flippmoke
Copy link
Member

Possible solution for #27
/cc @kkaefer @jfirebaugh

@jfirebaugh
Copy link
Contributor

Can we do this in a way that preserves the existing API with a default type of double?

@flippmoke
Copy link
Member Author

@jfirebaugh will that work?

@jfirebaugh
Copy link
Contributor

No, I mean make this a change that does not require any changes to the tests.

Supporting types other than double is a niche case, and technically outside of the GeoJSON spec. So we should preserve the types and function call syntax for for the existing, common case, avoiding breaking existing code, and introduce new calls and types for this added, uncommon case.

@flippmoke
Copy link
Member Author

@jfirebaugh as time goes on, I more and more would love to be able to support all types for encoding and decoding. I know this is an uncommon case for most, but in general I find it very nice if all our tools support all the geometry.hpp types possible. I would love to revisit this pull request and provide general support for all reasonable types.

@flippmoke flippmoke closed this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants