Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L.TileLayer.Canvas is not available in leaflet master #42

Closed
jieter opened this issue Mar 21, 2015 · 8 comments
Closed

L.TileLayer.Canvas is not available in leaflet master #42

jieter opened this issue Mar 21, 2015 · 8 comments

Comments

@jieter
Copy link
Contributor

jieter commented Mar 21, 2015

Another leaflet API change causing errors with leaflet-image:

TypeError: Expecting a function in instanceof check, but got [object Object]
at handleTileLayer (<path>/leaflet-image/index.js:60:56)
...

Problem is in https://github.com/mapbox/leaflet-image/blob/gh-pages/index.js#L60, as L.TileLayer.Canvas is removed from leaflet: 'Removed TileLayer.Canvas in favor of the much more flexible and powerful GridLayer.`

No completed yet, keeping backwards compatibility is easy, but it seems we now need to check each tile it it's canvas?

ref: Leaflet/Leaflet#3163

jieter added a commit to jieter/leaflet-image that referenced this issue Mar 21, 2015
@jieter
Copy link
Contributor Author

jieter commented Mar 21, 2015

This might be it, but it's not very well tested yet: gh-pages...jieter:fix-leaflet-master

Do you want to keep it backwards compatible with 0.7.3 or should we start with a separate branch to track leaflet-0.8/1.0

@tmcw
Copy link
Contributor

tmcw commented Mar 22, 2015

Definitely want to make an 0.8/1.0-compatible leaflet-image as a new, non-backwards-compatible semver major version bump. When 1.0 lands, it'll eliminate a lot of cruft in this library and likely prompt a rewrite.

@jieter
Copy link
Contributor Author

jieter commented Mar 22, 2015

So should I open a PR?

@mrohnstock
Copy link

would be great to have a working plugin, when leaflet 1.0 final is out!

@derwaldgeist
Copy link

I am using Leaflet as part of a Meteor package which is already on Leaflet 1.0.0-beta2. Is there any chance to make leaflet-image work with this beta version? I ran into the issue that L.TileLayer.Canvas is not defined.

@ClaudioCas
Copy link

leaflet 1.0 beta 2 is out, but the plugin still no compatible.
Any update about this issue?

@tmcw
Copy link
Contributor

tmcw commented Mar 31, 2016

Please open a PR if you want to see this happen.

@tmcw
Copy link
Contributor

tmcw commented May 18, 2016

Tested in 6ea4f54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants