Add programmatic annotation selection #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainbarbosa
force-pushed
the
nb-adds-programmatic-selection
branch
from
3fe0cef
to
e61d8d7
Compare
captainbarbosa
commented
Aug 12, 2019
annotations-framework-extension/MapboxAnnotationsExtension/Views/MGLAnnotationLayerView.h
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thank you for adding this pr. I'm not sure if we should also add a selectedAnnotation property to the annotationController because in the mapView we already "have" that, but thinking that is confusing that an annotationController.selectedAnnotation will not be equal to mapView.selectedAnnotation unless the feature is compared. Thoughts?
annotations-framework-extension/MapboxAnnotationsExtension/Views/MGLAnnotationLayerView.h
Outdated
Show resolved
Hide resolved
...ons-framework-extension/MapboxAnnotationsExtensionTests/MGLCircleAnnotationControllerTests.m
Show resolved
Hide resolved
...tions-framework-extension/MapboxAnnotationsExtensionTests/MGLLineAnnotationControllerTests.m
Show resolved
Hide resolved
...ns-framework-extension/MapboxAnnotationsExtensionTests/MGLPolygonAnnotationControllerTests.m
Show resolved
Hide resolved
...ons-framework-extension/MapboxAnnotationsExtensionTests/MGLSymbolAnnotationControllerTests.m
Show resolved
Hide resolved
|
@fabian-guerra I'm leaning towards providing a |
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to programmatically select/deselect an
MGLStyleAnnotation.I also added additional tests around
[MGLStyleAnnotationController addStyleAnnotation:].