Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapbox Directions API OSRM Name Fix #222

Merged
merged 7 commits into from
Dec 8, 2017
Merged

Mapbox Directions API OSRM Name Fix #222

merged 7 commits into from
Dec 8, 2017

Commits on Dec 7, 2017

  1. Fixing issue where querying a nonexistent waypoints[n].name keypath… 

    … in the result `json` will produce `""` instead of the expected `nil`. Adding logic to compensate for this.
    Jerrad Thramer committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    05e2f3a View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2017

  1. Adding Unit tests for API name handling on RouteOptions

    Jerrad Thramer committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    31a7cc7 View commit details
    Browse the repository at this point in the history

  2. Adding internal extension and happy-path polish.

    Jerrad Thramer committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    3c66121 View commit details
    Browse the repository at this point in the history

  3. Creating nonEmptyString extension that cleans up ternary check

    Jerrad Thramer committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    8c0f938 View commit details
    Browse the repository at this point in the history

  4. Adding extension for all targets, not just iOS

    Jerrad Thramer committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    024700b View commit details
    Browse the repository at this point in the history

  5. Yeah, this went a bit overboard.

    Jerrad Thramer committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    d679812 View commit details
    Browse the repository at this point in the history

  6. Updating podspec to point to all files in codebase, not just top-level

    Jerrad Thramer committed Dec 8, 2017
    Configuration menu
    Copy the full SHA
    778e7c4 View commit details
    Browse the repository at this point in the history