Expose more RouteStep properties to Obj-C #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
force-pushed
the
fred-objc-bridging-117
branch
from
b2ef8f4
to
7c96d9f
Compare
bsudekum
reviewed
Jan 2, 2018
MapboxDirections/MBRouteStep.swift
Outdated
| @@ -669,7 +696,7 @@ open class RouteStep: NSObject, NSSecureCoding { | |||
| guard let transportTypeDescription = decoder.decodeObject(of: NSString.self, forKey: "transportType") as String? else { | |||
| return nil | |||
| } | |||
| transportType = TransportType(description: transportTypeDescription) | |||
| transportType = TransportType(description: transportTypeDescription)! | |||
There was a problem hiding this comment.
This should probably be safely unwrapped.
|
Looks good. It looks like in a few places we're asserting that values are non-optional where as code around either unwraps the value or provides a default fallback. |
frederoni
force-pushed
the
fred-objc-bridging-117
branch
3 times, most recently
from
d7afc8a
to
a216f43
Compare
frederoni
force-pushed
the
fred-objc-bridging-117
branch
from
cca7437
to
b218ce4
Compare
bsudekum
approved these changes
Jan 3, 2018
|
Hi, When will you release a new MapboxDirections.swift pod which include bridge to ObjC for RouteStep.maneuverX variables ? Cheers |
This was referenced Jan 18, 2018
Closed
1ec5
added
the
backwards incompatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117
maneuverType,maneuverDirection, andtransportTypenow bridges to Obj-C.Another way to expose these properties to Obj-C could be to add an additional computed non-optional
bridgableManeuverTypeif optional chaining syntax is preferred within the framework.@1ec5 @bsudekum 👀