Public Response Types #406

JThramer · 2020-01-17T20:07:51Z

Implements #391.

To-Do:

Nothing! 🎉

Done:

Documentation
Add error case that handles a no-connection situation.
PR Comments
Fix Tests
DirectionsError needs to be Codable
DirectionsCredentials on Directions class that contains accessToken, host, and skuToken, copied to response on calculate
Convert a match response into a route response:
Matches need to be convertible to Routes
MapMatchingResponse needs to be convertible to RouteResponse
~~MatchOptions needs to be convertible to RouteOptions~~

cc @mapbox/navigation-ios

…pes. Still having issues with Codable.

Sources/MapboxDirections/Directions.swift

Sources/MapboxDirections/RouteResponse.swift

Sources/MapboxDirections/Directions.swift

Sources/MapboxDirections/RouteResponse.swift

Sources/MapboxDirections/MapMatching/MapMatchingResponse.swift

Sources/MapboxDirections/RouteResponse.swift

…n tokens into new `DirectionsCredentials` object, Reversing hacky match-to-route mechanism

…to fix tests

…ting failure via throwable initalizer

Sources/MapboxDirections/Directions.swift

# Conflicts: # Sources/MapboxDirections/Directions.swift

… of last-minute documentation

Sources/MapboxDirections/Directions.swift

… error.

Sources/MapboxDirections/Directions.swift

…ths. Thanks Sebastian!

Sources/MapboxDirections/DirectionsError.swift

Sources/MapboxDirections/MapMatching/MapMatchingResponse.swift

Sources/MapboxDirections/MapMatching/Match.swift

Udumft

There are some questions not clear for me. It may be not blocking since maybe I just lack some understanding of the map matching requests. Anyway please check the comments before merging.

Sources/MapboxDirections/MapMatching/MatchResponse.swift

Sources/MapboxDirections/MapMatching/MapMatchingResponse.swift

Udumft · 2020-04-04T10:02:51Z

At this point these changes heavily conflict with #388 . I would be important to have #406 merged before continuing #388.

WIP: Surfacing MapMatchingResponse and RouteResponse as public ty…

7db34bc

…pes. Still having issues with Codable.

JThramer self-assigned this Jan 17, 2020

JThramer added backwards incompatible changes that break backwards compatibility of public API improvement Improvement for an existing feature. labels Jan 17, 2020

JThramer added this to the v1.0 milestone Jan 17, 2020

1ec5 reviewed Jan 17, 2020

View reviewed changes

Jerrad Thramer added 9 commits January 17, 2020 14:24

Adding error-case initializer for RouteResponse/MapMatchingResponse

6edcb84

WIP: Removing options object from models, encapsulating authenticatio…

77f075b

…n tokens into new `DirectionsCredentials` object, Reversing hacky match-to-route mechanism

WIP: Integrating credentials.

ee31e7f

WIP: cutting down on errors

30b19dc

WIP: Fixed all compiler errors, Response model is now coherent, need …

2566411

…to fix tests

Fixing more tests, three to go.

48abd96

Fixing remaining tests.

d98e073

Fixing issue where SPM would fail compilation.

efb5f2e

Applying same SPM fix to MapMatchingResponse

6448a27

JThramer marked this pull request as ready for review February 13, 2020 00:17

Jerrad Thramer added 2 commits February 12, 2020 17:22

removing redundant logic

288d8af

Fixing issue where model mismatch results in a silent fail by propaga…

4e59896

…ting failure via throwable initalizer

1ec5 mentioned this pull request Feb 14, 2020

Suggestion: Consider using Result instead of optional response and error #414

Closed

SebastianOsinski reviewed Feb 17, 2020

View reviewed changes

Sources/MapboxDirections/Directions.swift Outdated Show resolved Hide resolved

Jerrad Thramer added 7 commits February 17, 2020 11:14

Adding documentation, and test change.

8c7b29d

Merge branch 'master' into jerrad/directions-calculate-interface

9a5b4ad

# Conflicts: # Sources/MapboxDirections/Directions.swift

Adding test coverage

49ad7d9

Adding offline error case, polish to remaining tests and adding a bit…

a024d57

… of last-minute documentation

Fixing final remaining issues

1d23371

Just kidding, found some more. I think we're now ready for review.

63b1941

typo

65e5e22

SebastianOsinski reviewed Feb 17, 2020

View reviewed changes

Sources/MapboxDirections/Directions.swift Outdated Show resolved Hide resolved

Implementing error case that wraps any kind of URLError-based network…

750be24

… error.

SebastianOsinski reviewed Feb 17, 2020

View reviewed changes

Sources/MapboxDirections/Directions.swift Outdated Show resolved Hide resolved

Jerrad Thramer added 2 commits February 17, 2020 14:49

Fixing broken test case

72a85fc

Implementing suggestion from @SebastianOsinski to remove dead code pa…

2243678

…ths. Thanks Sebastian!

JThramer requested a review from 1ec5 February 18, 2020 02:40

SebastianOsinski reviewed Feb 18, 2020

View reviewed changes

Sources/MapboxDirections/DirectionsError.swift Outdated Show resolved Hide resolved

Removing extraneous optional.

7c3644f

JThramer mentioned this pull request Mar 12, 2020

Directions Interface Compatibility Update mapbox/mapbox-navigation-ios#2350

Merged

8 tasks

Udumft reviewed Mar 13, 2020

View reviewed changes

Sources/MapboxDirections/MapMatching/MapMatchingResponse.swift Show resolved Hide resolved

Udumft reviewed Mar 13, 2020

View reviewed changes

Sources/MapboxDirections/MapMatching/Match.swift Show resolved Hide resolved

Jerrad Thramer added 2 commits April 3, 2020 12:09

Adding documentation for Weight

5065b92

Adding simple test for DirectionsCredentials

a6607fb

Udumft approved these changes Apr 4, 2020

View reviewed changes

Sources/MapboxDirections/MapMatching/MatchResponse.swift Show resolved Hide resolved

Sources/MapboxDirections/MapMatching/MapMatchingResponse.swift Show resolved Hide resolved

JThramer merged commit c915a0f into master Apr 4, 2020

JThramer deleted the jerrad/directions-calculate-interface branch April 4, 2020 14:43

1ec5 mentioned this pull request Apr 9, 2020

Revamp waypoint types #388

Draft

1ec5 modified the milestones: v1.0.0, v0.31.0 (v0.40) Apr 14, 2020

1ec5 mentioned this pull request May 29, 2020

Encapsulate responses in coherent public types #391

Closed

8 tasks

1ec5 mentioned this pull request Jun 15, 2020

Add ability to initialize route with visual and audio instructions. #430

Merged

1ec5 mentioned this pull request Jul 31, 2020

Misencoded geometry after converting map matching response to RouteResponse #439

Closed

This was referenced Sep 2, 2020

Remove DirectionsResult.routeIdentifier property #452

Closed

Route Refresh #420

Merged

1ec5 mentioned this pull request Jun 28, 2021

Leg source and destination are mismatched when route contains trackpoint or silent waypoint #556

Closed

jill-cardamon mentioned this pull request Jul 8, 2021

Fix bug where leg source and destination are mismatched when route contains trackpoint or silent waypoint #560

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Public Response Types #406

Public Response Types #406

JThramer commented Jan 17, 2020 •

edited

Udumft left a comment

Udumft commented Apr 4, 2020

Public Response Types #406

Public Response Types #406

Conversation

JThramer commented Jan 17, 2020 • edited

To-Do:

Done:

Udumft left a comment

Choose a reason for hiding this comment

Udumft commented Apr 4, 2020

JThramer commented Jan 17, 2020 •

edited