Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed SwiftyJSON dependency. Simplified JSON logic. #6

Closed
wants to merge 2 commits into from
Closed

Removed SwiftyJSON dependency. Simplified JSON logic. #6

wants to merge 2 commits into from

Conversation

harlanhaskins
Copy link

The SwiftyJSON dependency wasn't really necessary. This'll allow us to make a nice CocoaPod much easier.

@incanus
Copy link
Contributor

incanus commented Sep 1, 2015

Thanks for kicking this off @harlanhaskins. There's a lot going on in here aside from SwiftyJSON, though (Release build, whitespace, checkout-related things). Can you clean it up a bit so we can evaluate in context, and more importantly, possibly merge just the JSON improvements?

@harlanhaskins
Copy link
Author

Apologies for the whitespace; I ran ctrl+i.

I'm not quite sure why Xcode added that defaultConfigurationName thing -- I think that's something Xcode 6 does automatically.

@harlanhaskins
Copy link
Author

Also, I accidentally committed my Xcode workspace data because the project had no gitignore.
I can remove the gitignore, but I'd say it's a very useful thing to have.

@harlanhaskins
Copy link
Author

Also, the checkout file needed to be modified if SwiftyJSON is no longer going to be a hard dependency.

@incanus
Copy link
Contributor

incanus commented Oct 8, 2015

Closing in favor of review of #7.

@incanus incanus closed this Oct 8, 2015
@incanus incanus mentioned this pull request Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants