Update Xcode versions #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azarovalex
commented
Jul 19, 2022
| steps: | ||
| - checkout | ||
| # Limiting number of parallel jobs to avoid build crash bug. | ||
| - run: swift build --jobs=1 | ||
| - run: swift build |
There was a problem hiding this comment.
Doesn't crash anymore
MaximAlien
approved these changes
Jul 19, 2022
| @@ -491,8 +489,6 @@ | |||
| /* End PBXCopyFilesBuildPhase section */ | |||
|
|
|||
| /* Begin PBXFileReference section */ | |||
| 2B39DD3F270F034700ED68E4 /* CodingOperation.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; name = CodingOperation.swift; path = Sources/MapboxDirectionsCLI/CodingOperation.swift; sourceTree = "<group>"; }; | |||
There was a problem hiding this comment.
These two files are no longer present?
There was a problem hiding this comment.
CodingOperation.swift is still present:
There was a problem hiding this comment.
It was duplicated in project.pbxproj for some reason and Xcode removed duplicates automatically, everything still works.
This was referenced Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI is removing old Xcode images in 2 weeks, so we should update our CI pipeline.
PR is mostly bumping Xcode and runtime versions, but also fixed a dependency cycle errors in new Xcode version: